Re-introduce build-in type code for core types #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Only thing left to do is fixing issues around missing index operators on the arrays |
BastiaanOlij
commented
Sep 1, 2021
| ] | ||
|
|
||
| def is_included_type(type_name): | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
I could use a better name for this method :)
BastiaanOlij
commented
Sep 1, 2021
| #endif | ||
|
|
||
| #ifdef REAL_T_IS_DOUBLE | ||
| typedef double real_t; |
Collaborator
Author
There was a problem hiding this comment.
Unavoidable to re-introduce this. @reduz said something about when methods are called over the GD extension bridge doubles are always used even if members are defined as a float (where we do have a bug I think because it failed for me), in this case however we're re-implementing everything on our side so we need the right typing to be binary compatible.
BastiaanOlij
commented
Sep 1, 2021
Shatur
reviewed
Sep 1, 2021
BastiaanOlij
force-pushed
the
reintroduce_buildin_type_code
branch
2 times, most recently
from
a0e4ee8 to
84ae645
Compare
Collaborator
Author
|
We need a String constructor that takes a int64_t, disabled some string formatting code that relies on it for now, everything else is there, just needs testing. |
BastiaanOlij
force-pushed
the
reintroduce_buildin_type_code
branch
from
84ae645 to
a388155
Compare
BastiaanOlij
force-pushed
the
reintroduce_buildin_type_code
branch
from
a388155 to
c9dca8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduced the native source code for build in types such as
Vector3andRect3so we regain the ability of having full member access to these low level classes.Depends on godotengine/godot#52309