Conversation
|
Ok I've found Discord I will take inspiration from here |
There was a problem hiding this comment.
void-packages is in the process of removing all desktop files, icons and other data files from the repository. New desktop files likely won't be accepted. You should try convincing upstream to ship one themselves.
void-packages tries to avoid modifying upstream projects. The only major exceptions are
- applying patches to fix compilation errors
- applying patches to fix some bugs in the currently packaged version of the package (these are usually taken from development versions of the upstream project, so such patches get dropped when a new release including the fix is made)
- removing telemetry in certain cases
Adding functionality to the package (a desktop file) doesn't fall under these exceptions.
| do_build() { | ||
| # using node 20 | ||
| n 20 | ||
|
|
||
| # dependencies | ||
| npm run setup | ||
|
|
||
| # node gyp dependencies | ||
| npm install node-addon-api | ||
|
|
||
| # actual bruno | ||
| npm run build:web | ||
| npm run build:electron | ||
| } | ||
|
|
||
| do_install() { | ||
| local package_location="usr/lib/$pkgname" | ||
|
|
||
| vlicense license.md | ||
|
|
||
| vmkdir ${package_location} | ||
| vcopy packages/bruno-electron/out/linux-unpacked/* ${package_location} | ||
|
|
||
| vinstall ${FILESDIR}/bruno.desktop 644 usr/share/applications | ||
| vinstall assets/images/logo.png 644 usr/share/pixmaps bruno.png | ||
|
|
||
| vmkdir usr/bin | ||
| ln -sfr $DESTDIR/${package_location}/bruno $DESTDIR/usr/bin/bruno | ||
| } |
There was a problem hiding this comment.
This is a heavily customized build process which only supports x86_64. I am not knowledgeable of Node.js nor npm, so I cannot review this, but be aware that you might face more scrutiny from the Void maintainers because of this. They may be less willing to merge this package.
There was a problem hiding this comment.
That's fine for me if we do not merge.
My follow up question is, do you prefer I close the PR?
fabienjuif
force-pushed
the
new_package/bruno-desktop
branch
from
3c6b356 to
932885a
Compare
fabienjuif
force-pushed
the
new_package/bruno-desktop
branch
from
932885a to
41b3271
Compare
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
4 participants
This PR is in draft because I am unsure how we are supposed to deal with .AppImage files.
I still open the PR because it could help someone (?)
Testing the changes
New package
Local build testing