common/shlibs: remove stale libLLVMSPIRVLib.so.18.1 entry - #61733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
The standalone
SPIRV-LLVM-Translatortemplate was removed in 8b716a2, when the package became a metapackage subpackage ofllvm. The entry mappinglibLLVMSPIRVLib.so.18.1toSPIRV-LLVM-Translator-18.1.2_1still remains, a pkgname that is now a metapackage depending onSPIRV-LLVM-Translator${version}, so it cannot provide the specified soname. No srcpkg in the tree installslibLLVMSPIRVLib.so.18.1.Adding a
SPIRV-LLVM-Translator18package to pair with thellvm18still in the tree would be the other way to make this soname valid again, but it would have no consumer;mesais the only consumer in the tree and it usesSPIRV-LLVM-Translator21. Either way the line as written today is wrong.