vlogger: a couple of bugfixes.#2
Closed
CMB wants to merge 1 commit intovoid-linux:masterfrom
CMB:cmb-vlogger
Closed
vlogger: a couple of bugfixes.#2CMB wants to merge 1 commit intovoid-linux:masterfrom CMB:cmb-vlogger
CMB wants to merge 1 commit intovoid-linux:masterfrom
CMB:cmb-vlogger
Conversation
* Don't store the return value of getopt in a char. Storing in a char and comparing against -1 breaks on ARM, where char is unsigned. * The line argument to getline should point at a NULL char *. Otherwise, getline will treat *line as a pointer to an allocated buffer. With a little extra work, we could reuse the buffer, but always calling getline with *line == NULL is safe.
Member
|
Initializing |
robang74
pushed a commit
to robang74/void-runit
that referenced
this pull request
Aug 19, 2025
* Don't store the return value of getopt in a char. Storing in a char and comparing against -1 breaks on ARM, where char is unsigned. * The line argument to getline should point at a NULL char *. Otherwise, getline will treat *line as a pointer to an allocated buffer. With a little extra work, we could reuse the buffer, but always calling getline with *line == NULL is safe. Closes: void-linux#2 [via git-merge-pr]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and comparing against -1 breaks on ARM, where char is unsigned.
getline will treat *line as a pointer to an allocated buffer. With
a little extra work, we could reuse the buffer, but always calling getline
with *line == NULL is safe.