feat: allow task caching to github - #126
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0967e734a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return; | ||
| } | ||
|
|
||
| const primaryKey = `vite-task-${runnerOS}-${runnerArch}-${runId}-${runAttempt}`; |
There was a problem hiding this comment.
In workflows with multiple jobs on the same OS/architecture, every job shares this exact key because GITHUB_RUN_ID and GITHUB_RUN_ATTEMPT are workflow-wide. GitHub caches are immutable, so the first job to save reserves the key; later jobs either lose the save race or restore an exact hit and deliberately skip saving, meaning their task-cache entries are never persisted. Include a project/job or user-configurable discriminator so matrix and multi-project jobs can maintain independent caches.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
not sure how I'm supposed to be doing this..,? this was the suggested key on the GitHub Actions Caching page as far as I remember
| task-cache: | ||
| description: "Enable task caching via GitHub Actions" | ||
| required: false | ||
| default: "false" |
There was a problem hiding this comment.
The new input and output are absent from the public interface documentation: the Inputs table at README.md:329-344, Outputs table at README.md:350-355, and Caching section at README.md:357-375 still describe only dependency caching. Since the repository's marketplace README is how users discover and configure this action, the feature is effectively hidden and users cannot learn its cache path/key behavior or consume task-cache-hit; add the new input, output, and usage details there.
Useful? React with 👍 / 👎.
|
@KTrain5169 Need to update the README to inform users how to use this feature. |
|
thanks |
|
@fengmk2 pushed |
| run-install: true | ||
| ``` | ||
|
|
||
| ### With Task Caching |
There was a problem hiding this comment.
@KTrain5169 can you add a new test job for this new feature at https://github.com/voidzero-dev/setup-vp/blob/main/.github/workflows/test.yml ?
There was a problem hiding this comment.
I'm not sure what I'm supposed to test here, is it just trying to save and restore using the setup-vp action vs the regualr cache action?
2 participants
edit: didn't realise my edits didn't go through properly, sorry
this PR adds the ability for the Vite task cache to be saved to GitHub Actions cache, and restored on every run.
closes voidzero-dev/vite-plus#2013