Fix Clippy Warnings

[Brooooooklyn]

Fix Clippy Warnings

This issue tracks fixing all clippy warnings in the codebase. Warnings are organized by clippy rule, with the most common warnings listed first.

TODO List

High Priority (100+ warnings)

• clippy::disallowed_types (439 warnings)
  • Mainly std::path::Path, std::path::PathBuf, std::collections::HashMap, std::string::String
  • Should use vite_path types instead of std path types per project guidelines
• clippy::multiple_crate_versions (140 warnings)
  • Multiple versions of the same crate in dependency tree

Medium Priority (20-99 warnings)

• clippy::disallowed_macros (70 warnings)
  • Mainly std::format macro usage
• clippy::needless_borrows_for_generic_args (61 warnings)
• clippy::enum_variant_names (28 warnings)
• clippy::useless_vec (26 warnings)
• clippy::missing_errors_doc (26 warnings)
• clippy::default_trait_access (25 warnings)
  • Calling Type::default() instead of using trait
• clippy::semicolon_if_nothing_returned (24 warnings)
• clippy::disallowed_methods (20 warnings)
  • std::env::current_dir, str::replace, str::to_uppercase

Low Priority (10-19 warnings)

• clippy::redundant_closure_for_method_calls (18 warnings)
• clippy::items_after_statements (17 warnings)
• clippy::uninlined_format_args (16 warnings)
• clippy::needless_borrow (16 warnings)
• clippy::missing_panics_doc (14 warnings)
• clippy::too_many_lines (11 warnings)
• clippy::extra_unused_lifetimes (11 warnings)
• clippy::cast_possible_truncation (10 warnings)

Very Low Priority (2-9 warnings)

• clippy::ptr_arg (8 warnings)
• clippy::future_not_send (8 warnings)
• clippy::cognitive_complexity (7 warnings)
• clippy::zero_sized_map_values (6 warnings)
• clippy::significant_drop_tightening (6 warnings)
• clippy::option_if_let_else (6 warnings)
• clippy::needless_pass_by_value (6 warnings)
• clippy::large_futures (6 warnings)
• clippy::print_stdout (5 warnings)
• clippy::needless_collect (5 warnings)
• clippy::struct_field_names (4 warnings)
• clippy::similar_names (4 warnings)
• clippy::bool_assert_comparison (4 warnings)
  • crates/vite_task/src/lib.rs:653, 660, 670, 682
• clippy::wrong_self_convention (3 warnings)
• clippy::type_complexity (3 warnings)
• clippy::needless_range_loop (3 warnings)
• clippy::borrow_deref_ref (3 warnings)
  • crates/fspy_shared_unix/src/exec/which.rs:123, 164, 197
• clippy::useless_let_if_seq (2 warnings)
• clippy::unsafe_derive_deserialize (2 warnings)
• clippy::todo (2 warnings)
• clippy::single_char_pattern (2 warnings)
• clippy::redundant_clone (2 warnings)
• clippy::question_mark (2 warnings)
• clippy::missing_safety_doc (2 warnings)
• clippy::match_wildcard_for_single_variants (2 warnings)
• clippy::manual_let_else (2 warnings)
• clippy::cast_sign_loss (2 warnings)
• clippy::cast_precision_loss (2 warnings)

Single Instance (1 warning)

• clippy::print_stderr (1 warning)
• clippy::implicit_clone (1 warning)
• clippy::equatable_if_let (1 warning)
• clippy::collection_is_never_read (1 warning)
  • crates/vite_task/src/fingerprint.rs:206

Notes

• Total: 1,206 clippy warnings across 52 different rules
• Priority is based on warning count and alignment with project guidelines
• Some warnings (like disallowed_types) are intentional policy violations and should be fixed per CLAUDE.md guidelines

Related

Run clippy with:

cargo clippy --all-targets --all-features

[fengmk2]

merge to #622