Skip to content

chore: rename rolldown-vite directory to vite#1024

Merged
Boshen merged 10 commits intomainfrom
rename-rolldown-vite-to-vite
Mar 19, 2026
Merged

chore: rename rolldown-vite directory to vite#1024
Boshen merged 10 commits intomainfrom
rename-rolldown-vite-to-vite

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Mar 18, 2026

Summary

  • Rename the rolldown-vite gitignored directory (upstream vitejs/vite checkout) to just vite
  • Rename brand-rolldown-vite.tsbrand-vite.ts and update exported function name
  • Rename ROLLDOWN_VITE_DIR constant → VITE_DIR in sync-remote-deps and brand-vite
  • Update all references across config files, CI workflows, source code, docs, and snap test fixtures
  • The rolldown-vite npm package name in pnpm-workspace.yaml catalog is unchanged (it's a package name, not a directory)

🤖 Generated with Claude Code

The `rolldown-vite` directory is a git checkout of upstream vitejs/vite
used as a build input. The name was a legacy holdover that should be
simplified to just `vite`. This updates all references across config,
source, CI, docs, and test fixtures.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 6c34680
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69bb9479055e6f0009c46c17

Boshen and others added 4 commits March 18, 2026 21:48
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Boshen Boshen marked this pull request as ready for review March 19, 2026 02:31
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3027ada208

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Boshen and others added 2 commits March 19, 2026 11:12
Address review feedback: existing clones may still have a `rolldown-vite/`
directory after the rename. This adds automatic cleanup in sync-remote and
keeps `rolldown-vite` in .gitignore so it doesn't appear as untracked.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove `rolldown-vite` npm package from catalog and minimumReleaseAgeExclude
- Update all rolldown-vite references in rfcs/cli-output-polish.md

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e80d6cb922

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Boshen and others added 2 commits March 19, 2026 12:00
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the legacy directory cleanup inside the --clean guard so a normal
sync doesn't irreversibly delete the old checkout (which may contain
local branches or uncommitted work).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d71ceec08f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Boshen Boshen merged commit c2b1c15 into main Mar 19, 2026
44 checks passed
@Boshen Boshen deleted the rename-rolldown-vite-to-vite branch March 19, 2026 06:25
TheAlexLichter pushed a commit that referenced this pull request Mar 19, 2026
## Summary

- Rename the `rolldown-vite` gitignored directory (upstream vitejs/vite
checkout) to just `vite`
- Rename `brand-rolldown-vite.ts` → `brand-vite.ts` and update exported
function name
- Rename `ROLLDOWN_VITE_DIR` constant → `VITE_DIR` in sync-remote-deps
and brand-vite
- Update all references across config files, CI workflows, source code,
docs, and snap test fixtures
- The `rolldown-vite` npm package name in pnpm-workspace.yaml catalog is
unchanged (it's a package name, not a directory)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants