chore: rename rolldown-vite directory to vite#1024
Conversation
The `rolldown-vite` directory is a git checkout of upstream vitejs/vite used as a build input. The name was a legacy holdover that should be simplified to just `vite`. This updates all references across config, source, CI, docs, and test fixtures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for viteplus-preview canceled.
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3027ada208
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address review feedback: existing clones may still have a `rolldown-vite/` directory after the rename. This adds automatic cleanup in sync-remote and keeps `rolldown-vite` in .gitignore so it doesn't appear as untracked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove `rolldown-vite` npm package from catalog and minimumReleaseAgeExclude - Update all rolldown-vite references in rfcs/cli-output-polish.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e80d6cb922
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the legacy directory cleanup inside the --clean guard so a normal sync doesn't irreversibly delete the old checkout (which may contain local branches or uncommitted work). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d71ceec08f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
## Summary - Rename the `rolldown-vite` gitignored directory (upstream vitejs/vite checkout) to just `vite` - Rename `brand-rolldown-vite.ts` → `brand-vite.ts` and update exported function name - Rename `ROLLDOWN_VITE_DIR` constant → `VITE_DIR` in sync-remote-deps and brand-vite - Update all references across config files, CI workflows, source code, docs, and snap test fixtures - The `rolldown-vite` npm package name in pnpm-workspace.yaml catalog is unchanged (it's a package name, not a directory) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
Summary
rolldown-vitegitignored directory (upstream vitejs/vite checkout) to justvitebrand-rolldown-vite.ts→brand-vite.tsand update exported function nameROLLDOWN_VITE_DIRconstant →VITE_DIRin sync-remote-deps and brand-viterolldown-vitenpm package name in pnpm-workspace.yaml catalog is unchanged (it's a package name, not a directory)🤖 Generated with Claude Code