test(e2e): add cloudflare/vinext to ecosystem-ci#1050
Open
Conversation
Member
fengmk2
commented
Mar 19, 2026
fengmk2
commented
- Add vinext to repo.json with forceFreshMigration (already uses vite-plus)
- Add e2e matrix entry: build, check, test on node 24, ubuntu-only
- Update add-ecosystem-ci skill to handle projects already using vite-plus
- Add vinext to repo.json with forceFreshMigration (already uses vite-plus) - Add e2e matrix entry: build, check, test on node 24, ubuntu-only - Update add-ecosystem-ci skill to handle projects already using vite-plus
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
…n projects
Projects using pnpm catalogs (vinext, viteplus-ws-repro) have
`overrides: { vite: "catalog:" }` which takes precedence over the tgz
paths that vp migrate injects. This causes install failures because
vite-plus@0.0.0 depends on @voidzero-dev/vite-plus-test@0.0.0 which
doesn't exist on npm.
Fix: for forceFreshMigration projects, use the yaml package to update
pnpm-workspace.yaml overrides to point directly to tgz files for all
vite-plus packages. pnpm overrides take precedence over catalog entries.
✅ Deploy Preview for viteplus-preview canceled.
|
Remove yaml dependency (not available in CI e2e-test job) and use line-by-line parsing to replace the overrides section in pnpm-workspace.yaml. This correctly handles projects using pnpm catalogs by only modifying the overrides section without touching catalog entries.
…tion pnpm ignores pnpm-workspace.yaml overrides when pnpm.overrides exists in package.json. vp migrate also overwrites overrides set before it runs. Fix: add tgz overrides to pnpm.overrides AFTER migration so @voidzero-dev/vite-plus-core@0.0.0 and @voidzero-dev/vite-plus-test@0.0.0 resolve to the locally built tgz files.
When VITE_PLUS_FORCE_MIGRATE=1 is set, vp migrate forces full dependency rewriting even for projects already using vite-plus. This replaces the fragile hack logic in patch-project.ts that manually removed/re-added vite-plus and patched pnpm overrides. Now patch-project.ts simply sets the env var for projects with forceFreshMigration configured, and vp migrate handles everything correctly including pnpm.overrides in package.json.
Migration changes pnpm-workspace.yaml formatting (quote styles), so run vp check --fix first to normalize formatting before the project's own check command validates it.
Add verify-install.ts that checks vite, vitest, and vite-plus are all installed at version 0.0.0 (the local tgz version). This catches override failures early before running project commands.
vite and vitest are not direct dependencies in all ecosystem projects, only vite-plus is guaranteed to be present.
vite-plus itself was missing from pnpm.overrides, so projects using pnpm catalogs (e.g. vibe-dashboard) resolved vite-plus via catalog to an old version instead of the local tgz. Also update vibe-dashboard hash and add forceFreshMigration for vibe-dashboard and vp-config.
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.