Skip to content

fix(create): use bundler module resolution in monorepo template#1065

Merged
graphite-app[bot] merged 1 commit intomainfrom
fix-type-check-errors
Mar 20, 2026
Merged

fix(create): use bundler module resolution in monorepo template#1065
graphite-app[bot] merged 1 commit intomainfrom
fix-type-check-errors

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Mar 20, 2026

The monorepo template's tsconfig used nodenext module resolution which
requires explicit .js extensions on relative imports and breaks Vite
config type autocomplete. Switch to module: preserve and
moduleResolution: bundler which is correct for Vite projects.

Closes #1029

@netlify
Copy link

netlify bot commented Mar 20, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 4bc95a0
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69bd5e340204c90008e36286

Copy link
Member Author

fengmk2 commented Mar 20, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 self-assigned this Mar 20, 2026
@fengmk2 fengmk2 marked this pull request as ready for review March 20, 2026 08:08
@fengmk2 fengmk2 force-pushed the fix-type-check-errors branch from 6a253d0 to 1d766f6 Compare March 20, 2026 08:10
@graphite-app
Copy link

graphite-app bot commented Mar 20, 2026

Merge activity

The monorepo template's tsconfig used nodenext module resolution which
requires explicit .js extensions on relative imports and breaks Vite
config type autocomplete. Switch to module: preserve and
moduleResolution: bundler which is correct for Vite projects.

Closes #1029
@graphite-app graphite-app bot force-pushed the fix-type-check-errors branch from ea8bcb6 to 4bc95a0 Compare March 20, 2026 14:48
@graphite-app graphite-app bot merged commit 4bc95a0 into main Mar 20, 2026
23 checks passed
@graphite-app graphite-app bot deleted the fix-type-check-errors branch March 20, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types come out of the box broken in the monorepo template

3 participants