Skip to content

chore(tools): suppress Node.js warnings in snap tests for stable output#1070

Merged
fengmk2 merged 5 commits intovoidzero-dev:mainfrom
kazupon:fix/snap-test-node-warnings
Mar 21, 2026
Merged

chore(tools): suppress Node.js warnings in snap tests for stable output#1070
fengmk2 merged 5 commits intovoidzero-dev:mainfrom
kazupon:fix/snap-test-node-warnings

Conversation

@kazupon
Copy link
Collaborator

@kazupon kazupon commented Mar 20, 2026

Add NODE_NO_WARNINGS=1 to the snap test environment to suppress Node.js runtime warnings (e.g. MODULE_TYPELESS_PACKAGE_JSON) that vary across Node.js versions.

Why?

Without this, developers using a different Node.js version than the one pinned in .node-version (22.18.0) will see warnings in stderr that get captured into snap output, causing false diffs unrelated to actual code changes.

@netlify
Copy link

netlify bot commented Mar 20, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit fb194b3
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69bdf2b1d23b4600086a6e19

@kazupon kazupon requested review from Brooooooklyn and fengmk2 March 20, 2026 14:37
@fengmk2
Copy link
Member

fengmk2 commented Mar 21, 2026

packages/cli/snap-tests-global/command-staged-with-config snap test is flaky, I will skip it.

@fengmk2 fengmk2 merged commit f251ba9 into voidzero-dev:main Mar 21, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants