Merged
Conversation
Update all vite-task git dependencies (fspy, vite_glob, vite_path, vite_str, vite_task, vite_workspace) from 398a147f to 69cc6eba.
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
approved these changes
Mar 22, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2239eb752
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Cache hit icon changed from ✓ to ◉ - Cache miss icon changed from ✗ to ○ - New "not cached because it modified its input" messages - New --log CLI option in help output - Install tasks no longer replay cached output when inputs modified
- Add step 3 to ensure upstream dependencies (rolldown/vite) are cloned before running cargo check, preventing spurious failures - Include snap-tests-global path alongside snap-tests in snapshot update instructions - Renumber subsequent steps accordingly - Remove duplicate clone info from Notes section https://claude.ai/code/session_01RRnY32KVU6r6Y8eqfSkwEb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
voidzero-dev/vite-task@398a147...69cc6eb#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed