Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Add snap tests to verify vp build caching works correctly: - vp-build-cache: single package build cache hit - vp-build-cache-monorepo: monorepo with two packages, both hit cache
Remove ignoredPlatforms and ls commands so tests run on all platforms.
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modules/.vite-temp/from fspy trackingvp packbuildsgrep 'cache hit'in snap test steps for stable outputVite writes transient compiled config files to
node_modules/.vite-temp/during builds. These files were tracked by fspy as both read and written, causing a read-write overlap that prevented caching with "not cached because it modified its input".vite-task changelog: voidzero-dev/vite-task@69cc6eb...ffd0eed#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
Test plan
cargo checkpassescargo testpasses for all vite-plus cratescommand-pack-monorepoverifies cache hitscommand-packverifies cache hitsCloses #1095
🤖 Generated with Claude Code