fix(windows): handle spurious key events in command picker#1100
Merged
fengmk2 merged 3 commits intovoidzero-dev:mainfrom Mar 23, 2026
Merged
fix(windows): handle spurious key events in command picker#1100fengmk2 merged 3 commits intovoidzero-dev:mainfrom
fengmk2 merged 3 commits intovoidzero-dev:mainfrom
Conversation
On Windows CMD/PowerShell, crossterm sends both Press and Release events for each keystroke, which caused the picker to immediately select the first option when launched. This change filters to only handle KeyEventKind::Press events, ignoring Release events.
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, running
vpdirectly in Windows Terminal (PowerShell or CMD) causes the command picker to immediately receive an Enter key Release event, which incorrectly triggers thecreatesubcommand without user input. This issue does not occur in VS Code Terminal.Additionally, when running under
conhost.exe, user input characters are duplicated.Root Cause
This is caused by a known Windows Terminal issue that key events are generated simultaneously.
Fix
Check
KeyEventKindbeforehandle_key_eventRelated Issues
microsoft/terminal#8440
crossterm-rs/crossterm#978