fix(migrate): warn on uncoercible husky version instead of false positive#1124
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1a8140c to
df75cfc
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@jong-kyung ci fails, please check again. |
Thank you for review. The |
|
@jong-kyung Thanks! |
Summary
vp migratewhen husky version is a dist-tag ("latest","next") or other non-semver stringsemver.coerce()returnsnull, warn the user to specify a semver-compatible version instead of silently falling back to'0.0.0'checkUnsupportedHuskyVersionreturn type frombooleantostring | nullto co-locate message logic with version checkingCloses #1114