fix(create): show helpful error for unknown vite: templates#1130
Merged
fengmk2 merged 4 commits intovoidzero-dev:mainfrom Mar 25, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
approved these changes
Mar 25, 2026
Member
|
one snap test flaky, I will fix it first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
resolves #1128
Description
When an unknown template with a vite: prefix (e.g., vite:test) was specified in the vp create command, the CLI would crash with an unhandled ENOENT error instead of displaying a user-friendly error message.
This happened because the vite:application command is rewritten to create-vite@latest before being passed to subsequent logic. Consequently, any vite:* command remaining at the fall-through stage is inevitably an unknown command. By detecting this and implementing an early return, we have prevented both the crash and the confusing error message.
Additionally, this fix adds protection to the setPackageName call by checking the exit code. This prevents the function from attempting to read package.json from a directory that was never created.
Manual Verification Results
Specifying an unknown template -> An error message is displayed
❯ vp create vite:test Using default package name: remaining-very "vite:test" is an unknown built-in template. Run vp create --list to see available templates.Specifying an existing template -> Completes successfully (no regression)