Skip to content

fix(env): remove misleading PATH position check in vp env doctor #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 1 commit into from
Mar 25, 2026
Merged

fix(env): remove misleading PATH position check in vp env doctor #1140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions crates/vite_global_cli/src/commands/env/doctor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,29 +408,18 @@ async fn check_path() -> bool {

// Check if bin directory is in PATH
let bin_path = bin_dir.as_path();
let bin_position = paths.iter().position(|p| p == bin_path);
let bin_in_path = paths.iter().any(|p| p == bin_path);

let bin_display = abbreviate_home(&bin_dir.as_path().display().to_string());

match bin_position {
Some(0) => {
print_check(&output::CHECK.green().to_string(), "vp", "first in PATH");
}
Some(pos) => {
print_check(
&output::WARN_SIGN.yellow().to_string(),
"vp",
&format!("in PATH at position {pos}").yellow().to_string(),
);
print_hint("For best results, bin should be first in PATH.");
}
None => {
print_check(&output::CROSS.red().to_string(), "vp", &"not in PATH".red().to_string());
print_hint(&format!("Expected: {bin_display}"));
println!();
print_path_fix(&bin_dir);
return false;
}
if bin_in_path {
print_check(&output::CHECK.green().to_string(), "vp", "in PATH");
} else {
print_check(&output::CROSS.red().to_string(), "vp", &"not in PATH".red().to_string());
print_hint(&format!("Expected: {bin_display}"));
println!();
print_path_fix(&bin_dir);
return false;
}

// Show which tool would be executed for each shim
Expand Down
Loading