fix(runner): ignore changes inside .git#115
Merged
Brooooooklyn merged 1 commit intomainfrom Sep 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a task caching issue where file accesses inside the .git directory were incorrectly invalidating the lint task cache. The fix ignores file accesses to paths within the .git directory when tracking changes for cache invalidation.
- Added logic to filter out
.gitdirectory accesses from cache tracking - Added comprehensive test case to verify
.gitchanges don't invalidate cache
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/vite_task/src/execute.rs | Implements the core fix by filtering out .git directory accesses |
| packages/cli/tests/cases/lint-dot-git/steps.json | Defines test commands to verify cache behavior with .git changes |
| packages/cli/tests/cases/lint-dot-git/snap.txt | Expected test output showing cache hit after .git modifications |
| packages/cli/tests/cases/lint-dot-git/package.json | Minimal package.json for test case setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
branchseer
force-pushed
the
09-15-fix_runner_ignore_changes_inside_.git
branch
from
53959d3 to
0aa9425
Compare
Brooooooklyn
approved these changes
Sep 15, 2025
branchseer
force-pushed
the
09-15-fix_runner_ignore_changes_inside_.git
branch
from
0aa9425 to
864fb28
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
fengmk2
approved these changes
Sep 15, 2025
branchseer
force-pushed
the
09-15-fix_runner_ignore_changes_inside_.git
branch
from
864fb28 to
ed60aa2
Compare
Brooooooklyn
force-pushed
the
09-15-fix_runner_ignore_changes_inside_.git
branch
from
ed60aa2 to
cb5b02a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: branchseer <dk4rest@gmail.com>
Brooooooklyn
force-pushed
the
09-15-fix_runner_ignore_changes_inside_.git
branch
from
cb5b02a to
e88ed00
Compare
Brooooooklyn
deleted the
09-15-fix_runner_ignore_changes_inside_.git
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Ignore
.gitdirectory when tracking file accesses for task caching.What changed?
Added a condition in
execute_taskto ignore file accesses to paths that start with.gitor exactly match.git. This prevents oxlint's reads inside the.gitdirectory from invalidating the cache.Added a test case to verify that changes inside the
.gitdirectory don't invalidate the lint cache.