fix(config): auto-set git core.hooksPath without prompting#1157
Open
fix(config): auto-set git core.hooksPath without prompting#1157
Conversation
When a user clones a project with staged config in vite.config.ts and manually runs `vp config`, the prompt was incorrectly shown because hook shims don't exist after clone (they're gitignored). The existing staged config is sufficient signal that the project opted into hooks. Add `hasStagedConfigInViteConfig(root)` check to the prompt condition so projects with staged config auto-install hooks without prompting. Closes #1154
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Projects like npmx.dev call `vp config` from `postinstall` instead of `prepare`. Extend the lifecycle detection to also recognize `postinstall` so hooks are auto-installed without prompting in both cases. Closes #1154
Update all sections to reflect that vp config now recognizes both prepare and postinstall lifecycle events, and skips the interactive prompt when staged config already exists in vite.config.ts.
fengmk2
changed the title
Member
Author
|
Before merging, I will first release a test version for manual verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp configwhenstagedconfig already exists invite.config.ts— the project has already opted into hookspostinstalllifecycle in addition toprepare— projects that callvp configfrompostinstall(e.g. npmx.dev) now auto-install hooks without promptingvp confighooks setup flow diagram and prompt decision table to RFCTest plan
command-config-auto-hooks— verifies auto-install when staged config exists (no lifecycle env)command-config-postinstall-auto-hooks— verifies auto-install from postinstall lifecyclecommand-config-*snap tests pass unchangedCloses #1154