fix(ci): retry failed snap test cases instead of skipping flaky tests#1209
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 30, 2026
Merged
fix(ci): retry failed snap test cases instead of skipping flaky tests#1209graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
approved these changes
Mar 30, 2026
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
…and Windows (#1209) Only run this test on Linux to avoid flaky failures.
graphite-app
bot
force-pushed
the
ignore-flaky-test
branch
from
0b09691 to
7feb2e7
Compare
Member
Author
|
I will change it to retry instead of ignore |
fengmk2
added a commit
that referenced
this pull request
Mar 30, 2026
…tests Revert the ignoredPlatforms skip on create-next-command-library and instead add a shared retry script that re-runs only the specific snap test cases whose snap.txt changed, up to 2 times. Closes #1209
fengmk2
changed the title
fengmk2
added a commit
that referenced
this pull request
Mar 30, 2026
…tests Revert the ignoredPlatforms skip on create-next-command-library and instead add a shared retry script that re-runs only the specific snap test cases whose snap.txt changed, up to 2 times. Closes #1209
fengmk2
force-pushed
the
ignore-flaky-test
branch
from
e27d9a1 to
1a3b903
Compare
fengmk2
added a commit
that referenced
this pull request
Mar 30, 2026
…and Windows (#1209) Only run this test on Linux to avoid flaky failures.
fengmk2
added a commit
that referenced
this pull request
Mar 30, 2026
…tests Revert the ignoredPlatforms skip on create-next-command-library and instead add a shared retry script that re-runs only the specific snap test cases whose snap.txt changed, up to 2 times. Closes #1209
fengmk2
force-pushed
the
ignore-flaky-test
branch
from
1a3b903 to
a039baf
Compare
…#1209) ## Summary - Revert the `ignoredPlatforms` skip on `create-next-command-library` so it runs on all platforms again - Add `.github/scripts/retry-failed-snap-tests.sh` that retries only the specific snap test cases whose `snap.txt` changed, up to 2 times - Both `cli-snap-test` and `cli-e2e-test-musl` jobs use the shared script ## Test plan - [x] CI passes on all platforms (Linux, macOS, Windows) - [x] `create-next-command-library` snap test runs on macOS and Windows - [x] If a snap test is flaky, CI retries only that specific case instead of failing immediately
graphite-app
bot
force-pushed
the
ignore-flaky-test
branch
from
a039baf to
6910ba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignoredPlatformsskip oncreate-next-command-libraryso it runs on all platforms again.github/scripts/retry-failed-snap-tests.shthat retries only the specific snap test cases whosesnap.txtchanged, up to 2 timescli-snap-testandcli-e2e-test-musljobs use the shared scriptTest plan
create-next-command-librarysnap test runs on macOS and Windows