chore(test): add #[serial] to env-var tests to prevent concurrent access races#1223
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 31, 2026
Merged
chore(test): add #[serial] to env-var tests to prevent concurrent access races#1223graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
cpojer
approved these changes
Mar 31, 2026
Merge activity
|
…s races (#1223) Tests that manipulate process env vars (VP_SHIM_TOOL, VITE_PLUS_SHIM_TOOL, PATH) without #[serial] can race with other tests running in parallel, causing flaky CI failures. Ensure all such tests are serialized and clear all related env vars before running. Also document env var testing guidelines in CLAUDE.md.
graphite-app
bot
force-pushed
the
fix-flaky-unittest
branch
from
2e15cfe to
5df0b36
Compare
fengmk2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that manipulate process env vars (VP_SHIM_TOOL, VITE_PLUS_SHIM_TOOL,
PATH) without #[serial] can race with other tests running in parallel,
causing flaky CI failures. Ensure all such tests are serialized and clear
all related env vars before running.
Also document env var testing guidelines in CLAUDE.md.