fix: avoid SetGlobalDefaultError panic when rolldown devtools is enabled#1364
Draft
fix: avoid SetGlobalDefaultError panic when rolldown devtools is enabled#1364
Conversation
On Windows, crossterm emits both Press and Release events for each key press. Without filtering for Press-only, arrow keys in the `vp i` package manager prompt were processed twice per press (move then move back), making them appear non-functional. Closes #1361
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Skip installing a global tracing subscriber during NAPI module init when VITE_LOG is not set. Previously, init_tracing() always installed a no-op subscriber (empty Targets filter) that occupied the global default slot. When rolldown devtools was later enabled via build.rolldownOptions.devtools, DebugTracer::init() would panic trying to claim the already-occupied slot. Now the global default slot stays free for other components unless VITE_LOG is explicitly set, and even then try_init() is used for graceful fallback. Closes #1356
fengmk2
force-pushed
the
fix-devtools-1356
branch
from
b913a30 to
a493b94
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip installing a global tracing subscriber during NAPI module init when
VITE_LOG is not set. Previously, init_tracing() always installed a no-op
subscriber (empty Targets filter) that occupied the global default slot.
When rolldown devtools was later enabled via build.rolldownOptions.devtools,
DebugTracer::init() would panic trying to claim the already-occupied slot.
Now the global default slot stays free for other components unless VITE_LOG
is explicitly set, and even then try_init() is used for graceful fallback.
Closes #1356