fix(cli)!: stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts by fengmk2 · Pull Request #1378 · voidzero-dev/vite-plus

fengmk2 · 2026-04-14T02:33:47Z

Breaking change

vp lint and vp fmt no longer inject -c <workspace-root vite.config.ts> into the underlying oxlint / oxfmt invocation.

Before this PR, every invocation was pinned to the workspace-root config regardless of cwd. That defeated oxlint 1.60 / oxfmt 0.45's new nested-config auto-discovery (gated on VP_VERSION, which vp already sets — see oxc-project/oxc#20416 / oxc-project/oxc#20417).

After this PR, config selection is delegated entirely to oxlint / oxfmt:

Running from a subpackage cwd uses that subpackage's nearest vite.config.ts (or .oxlintrc* for lint) — nested overrides apply.
Running from the workspace root uses the root config — but oxlint auto-discovery also matches .oxlintrc.json / .oxlintrc.jsonc in intermediate directories. If any such file sits between cwd and the file being linted, its config wins over the root's.

Migration

Repos relying on the old "root config wins everywhere" behavior need one of:

Remove stray nested .oxlintrc* / vite.config.ts files from subpackages that shouldn't have their own lint/fmt scope.
Update nested configs to extends the root.
Restructure so top-level commands always run from the root cwd with no intermediate configs.

Refs oxc-project/oxc#20416

netlify · 2026-04-14T02:33:52Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`234da41`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69ddfccef1ea79049adbfca4
😎 Deploy Preview	https://deploy-preview-1378--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

fengmk2 · 2026-04-14T02:34:01Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

fengmk2 · 2026-04-14T04:03:48Z

@cursor review

leaysgur

LGTM for snapshots

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e94193d. Configure here.}

packages/cli/binding/src/cli/resolver.rs

cpojer · 2026-04-14T06:29:41Z

Direction makes sense, deferring to @leaysgur for approving the code changes.

…fig.ts loading bug Mirrors the layout from oxc-project/oxc#20416: a root `vite.config.ts` plus `packages/proj-1/vite.config.ts`. Running `vp lint` / `vp fmt` from `packages/proj-1` should pick up the nested config, but the committed snap shows both commands exit with [1] applying the root config instead (root `no-debugger: error` vs proj-1 `off`, root `singleQuote: true` vs proj-1 `false`). Refs oxc-project/oxc#20416

The repo-level `vp check --fix` lint-staged hook was reformatting the snap test fixture to match the repo's own `singleQuote: true`, which erased the double-quoted string the fmt reproduction depends on. Exclude the fixture directory from the repo's `fmt.ignorePatterns` and restore the fixture source so the committed snap.txt captures both the lint and fmt failures.

oxlint 1.60.0 and oxfmt 0.45.0 auto-discover the nearest vite.config.ts from cwd up (gated by VP_VERSION, which vp injects via merge_resolved_envs_with_version and the bin wrappers). Injecting `-c <root vite.config.ts>` broke the nested-workspace case: running `vp lint` / `vp fmt` from a sub-package applied the root config instead of the sub-package's own config. Drop the -c injection from the Lint/Fmt resolver arms and propagate the now-unused resolved_vite_config parameter removal through resolve_and_execute, resolve_and_capture_output, and their callers. resolve_universal_vite_config() stays for check/mod.rs's LintMessageKind derivation. Snapshot updates: - nested-oxc-config-proj-1: both vp lint and vp fmt --check pass when run from packages/proj-1 (regression test for oxc-project/oxc#20416). - workspace-lint-subpackage: sub-package's no-console:off now wins over root's no-console:warn as documented. Closes oxc-project/oxc#20416

Add root-cwd cases that must fail under the root config's strict rules, complementing the existing proj-1 cwd cases that pass under the nested override.

The resolved config is now only consumed by LintMessageKind, so calling the JS-runtime resolver unconditionally wasted a NAPI round-trip on `vp check --no-lint` and fmt-only paths.

Root config's `no-console: warn` should flag app-a's console.log when vp lint runs from the workspace root, complementing the existing nested-override case where the sub-workspace's `no-console: off` wins.

Documents two behaviors observed while investigating why `vp lint` at the repo root was leaking snap-test fixture diagnostics: 1. Root vite.config.ts `lint.ignorePatterns` (wildcard-prefixed) does filter files out of the lint walk when no nearer oxlint config exists — packages/ignored/src/index.js is skipped despite its console.log. 2. Nested vite.config.ts in a subpackage (packages/included/ vite.config.ts, no-console:off) is NOT consulted when cwd is the workspace root; the root's no-console:error still flags it.

fengmk2 · 2026-04-14T07:42:36Z

@cpojer @leaysgur Since this change would result in a breaking update, I need more time for testing and validation as well as user documentation. Therefore, I've decided not to include this feature in version 0.1.17 and will release it next week instead.

fengmk2 · 2026-04-14T07:47:17Z

package.json

    "install-global-cli": "tool install-global-cli",
    "tsgo": "tsgo -b tsconfig.json",
-    "lint": "vp lint --type-aware --type-check --threads 4",
+    "check": "vp check --disable-nested-config",


@leaysgur @camc314 can we support disable nested config in vite.config.ts too?

If you're asking whether that applies even when using vite.config.ts in VP mode, I think the answer is yes.

Adds a dedicated Nested Configuration guide covering how `vp lint` and `vp fmt` select a `vite.config.ts`, with an explicit note on the asymmetry between the two: `vp lint` is cwd-only, while `vp fmt` walks up until it finds a config. Cross-links it from the Lint and Format pages and the Check sidebar. Adds snap-tests/docs-nested-config to pin each documented claim (cwd walk-up for fmt, cwd-only fallback for lint, root-cwd wins over nested configs, `-c <path>` bypasses cwd resolution) so the guide stays in sync with actual behavior.

fengmk2 · 2026-04-14T08:36:15Z

docs/guide/nested-config.md

+`vp lint` and `vp fmt` resolve configuration from the **current working directory** (cwd), but with one subtle difference:
+
+- **`vp lint`** — cwd-only. Uses `<cwd>/vite.config.ts` if it exists. If not, falls back to Oxlint's built-in defaults — it does **not** walk up to find an ancestor config.
+- **`vp fmt`** — cwd walk-up. Walks up from cwd and uses the first `vite.config.ts` it finds. If none is found anywhere up to the filesystem root, falls back to Oxfmt defaults.


@leaysgur Curious why the logic of oxlint and oxfmt is different. 😢

…root Adds claim 2c/2d to probe deeper cwds where lint and fmt diverge (lint stays on oxlint defaults from pkg-a/src, fmt walks up to pkg-a's vite.config.ts), and replaces the targeted per-package lint commands in claim 3 with the bare `vp lint --threads=1` / `vp fmt --check` invocations a user would actually run. `--threads=1` keeps the multi-error output order stable across snapshot runs.

This comment was marked as resolved.

Sign in to view

fengmk2 self-assigned this Apr 14, 2026

fengmk2 force-pushed the fix-nested-oxc-config branch from 17e9ca9 to b17614e Compare April 14, 2026 03:58

fengmk2 marked this pull request as ready for review April 14, 2026 04:02

fengmk2 changed the title ~~test(snap): add nested-oxc-config-proj-1 to reproduce nested vite.config.ts loading bug~~ fix(cli): stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts Apr 14, 2026

fengmk2 requested review from cpojer and leaysgur April 14, 2026 04:02

fengmk2 added the test: e2e Auto run e2e tests label Apr 14, 2026 — with Graphite App

leaysgur approved these changes Apr 14, 2026

View reviewed changes

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/cli/binding/src/cli/resolver.rs Show resolved Hide resolved

cpojer removed their request for review April 14, 2026 06:29

fengmk2 changed the title ~~fix(cli): stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts~~ fix(cli)!: stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts Apr 14, 2026

fengmk2 added 9 commits April 14, 2026 15:34

test(snap): cover root-workspace fallback in nested-oxc-config-proj-1

12b1f3f

Add root-cwd cases that must fail under the root config's strict rules, complementing the existing proj-1 cwd cases that pass under the nested override.

test(snap): drop unused pnpm-lock.yaml from nested-oxc-config-proj-1

5a9deeb

perf(check): defer resolve_universal_vite_config to the lint branch

36f0a05

The resolved config is now only consumed by LintMessageKind, so calling the JS-runtime resolver unconditionally wasted a NAPI round-trip on `vp check --no-lint` and fmt-only paths.

test(snap): cover root-cwd lint in workspace-lint-subpackage

3dc07ba

Root config's `no-console: warn` should flag app-a's console.log when vp lint runs from the workspace root, complementing the existing nested-override case where the sub-workspace's `no-console: off` wins.

chore: add disable-nested-config

298df47

fengmk2 changed the base branch from main to graphite-base/1378 April 14, 2026 07:39

fengmk2 force-pushed the fix-nested-oxc-config branch from 11e4980 to 298df47 Compare April 14, 2026 07:39

fengmk2 changed the base branch from graphite-base/1378 to support-disable-nested-config April 14, 2026 07:40

fengmk2 mentioned this pull request Apr 14, 2026

feat(check): support --disable-nested-config flag #1380

Open

fengmk2 changed the title ~~fix(cli)!: stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts~~ fix(cli)!: stop injecting -c config; add vp check --disable-nested-config Apr 14, 2026

fengmk2 changed the title ~~fix(cli)!: stop injecting -c config; add vp check --disable-nested-config~~ fix(cli)!: stop injecting -c config and support nested config Apr 14, 2026

fengmk2 changed the title ~~fix(cli)!: stop injecting -c config and support nested config~~ fix(cli)!: stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts Apr 14, 2026

fengmk2 commented Apr 14, 2026

View reviewed changes

fengmk2 marked this pull request as draft April 14, 2026 07:50

fengmk2 linked an issue Apr 14, 2026 that may be closed by this pull request

Vp lint ignores nested package ignorePattern #997

Open

4 tasks

fengmk2 mentioned this pull request Apr 14, 2026

fix(cli): merge root and sub-package lint configs for vp lint #1115

Closed

fengmk2 commented Apr 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli)!: stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts#1378

fix(cli)!: stop injecting -c config so oxlint/oxfmt pick up nested vite.config.ts#1378
fengmk2 wants to merge 11 commits intosupport-disable-nested-configfrom
fix-nested-oxc-config

fengmk2 commented Apr 14, 2026 •

edited

Loading

Uh oh!

netlify bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

fengmk2 commented Apr 14, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

fengmk2 commented Apr 14, 2026

Uh oh!

leaysgur left a comment •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

cpojer commented Apr 14, 2026

Uh oh!

fengmk2 commented Apr 14, 2026

Uh oh!

fengmk2 Apr 14, 2026

Uh oh!

leaysgur Apr 14, 2026

Uh oh!

fengmk2 Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fengmk2 commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Migration

Uh oh!

netlify bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview ready!

Uh oh!

fengmk2 commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

This comment was marked as resolved.

fengmk2 commented Apr 14, 2026

Uh oh!

leaysgur left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cpojer commented Apr 14, 2026

Uh oh!

fengmk2 commented Apr 14, 2026

Uh oh!

fengmk2 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

leaysgur Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

fengmk2 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fengmk2 commented Apr 14, 2026 •

edited

Loading

netlify bot commented Apr 14, 2026 •

edited

Loading

fengmk2 commented Apr 14, 2026 •

edited

Loading

leaysgur left a comment •

edited

Loading