docs: improve "before" ci usage to actual use case#1551
Merged
Conversation
Signed-off-by: Mister-Hope <mister-hope@outlook.com>
✅ Deploy Preview for viteplus-preview canceled.
|
Signed-off-by: Mister-Hope <mister-hope@outlook.com>
Signed-off-by: Mister-Hope <mister-hope@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI guide to show a more realistic pnpm-based “Before” workflow when comparing against voidzero-dev/setup-vp, aiming to better reflect common GitHub Actions usage patterns.
Changes:
- Updates the
setup-vpexample to use Node24. - Reworks the “Before” pnpm workflow example (pnpm version, setup-node caching, removes manual store/cache steps).
- Adds an explicit
pnpm checkstep to align with Vite+ checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
approved these changes
May 11, 2026
Ari4ka
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is pnpm documentation manager & maintainer.
It would be better if a better case for pnpm is used.
Here, I choose not to omit the
versionkey (though in most project pnpm users may already havepackageMangerfield so they don't need it)Outputting
pnpm store pathis useless, andactions/node-setupcould handle cache for pnpm withcache: pnpm. So the changed result is more natural.Besides, a
pnpm check(forpnpm run check) is added to align vite plus checks.This also aligns the former node 22 to 24 with the latter ones