fix(docs): include docs/ in fmt and lint#1552
Merged
Merged
Conversation
Remove docs/** from fmt.ignorePatterns and lint.ignorePatterns in vite.config.ts so the docs directory is formatted and linted with the rest of the repo. Fix two lint errors surfaced in docs/.vitepress: - tsconfig.json: this config is editor/lint-only (no build script consumes it), so replace noEmit: false + emitDeclarationOnly/outDir/ declaration with noEmit: true to resolve the rootDir error. - config.mts: drop tsconfigPaths: true. Vitepress bundles upstream vite@7.3.1 which does not have that option on ResolveOptions (only Vite+'s fork does), so it was silently ignored at runtime. The alias entries below already cover the path mappings.
✅ Deploy Preview for viteplus-preview canceled.
|
cpojer
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/**fromfmt.ignorePatternsandlint.ignorePatternsinvite.config.tsso thedocs/directory is formatted and linted with the rest of the repo.docs/.vitepresswas included:docs/.vitepress/tsconfig.json: replacenoEmit: false+emitDeclarationOnly/outDir/declarationwithnoEmit: true. This config is editor/lint-only (no build script consumes it), so emit settings were spurious and triggered arootDirerror.docs/.vitepress/config.mts: droptsconfigPaths: true. Vitepress bundles upstreamvite@7.3.1which doesn't have that option onResolveOptions(only Vite+'s fork does), so it was silently ignored at runtime. Thealiasentries below already cover the needed path mappings.Test plan
vp fmt— reformats 6 previously-skipped files underdocs/vp lint— 0 warnings, 0 errors across 182 files