ci(clippy): enable cargo clippy with -D warnings#1579
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd77df4d41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Port clippy lint configuration from rolldown and turn the lint step on in CI so future warnings fail the build. Existing legacy violations of the disallowed_* / print_stdout rules are suppressed at the crate root via `#![allow(...)]`, keeping enforcement available for new code in clean crates. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Drop stale dashmap entry under rolldown_devtools (upstream removed it) - vp check --fix yaml formatting in ci.yml Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd425f2211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Closes #622
Summary
.clippy.toml) into vite-plusallowoverrides inCargo.tomlfor pedantic/nursery/cargo noise the project intentionally toleratescargo clippy --all-targets --all-features -- -D warningsin the lint CI job (previously commented out)disallowed_*/print_stdoutrules at crate roots via#![allow(...)]; existing in-place fixes (uninlined_format_args,collapsible_if,mul_add,f64::from, etc.) round out the rest🤖 Generated with Claude Code