fix(cli): expose configured package manager to direct commands#1696
Draft
jong-kyung wants to merge 4 commits into
Draft
fix(cli): expose configured package manager to direct commands#1696jong-kyung wants to merge 4 commits into
jong-kyung wants to merge 4 commits into
Conversation
Prepend the managed package manager bin from an explicit packageManager field to direct built-in command environments so tools spawned by vp test can find the configured package manager without relying on the user's shell PATH. Keep the behavior limited to explicit packageManager metadata and avoid lockfile inference or package.json mutation.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
jong-kyung
changed the title
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
force-pushed
the
fix/direct-package-manager-path
branch
from
ea6bbba to
e720b64
Compare
jong-kyung
force-pushed
the
fix/direct-package-manager-path
branch
from
e720b64 to
efad700
Compare
Avoid failing direct built-ins when explicit package-manager resolution or ensure fails before the underlying tool starts. Align regression coverage with the global CLI path using a sanitized-PATH pnpm fixture.
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direct built-in commands like
vp test --coveragenow expose the package manager declared in the workspace rootpackage.json#packageManagerto child processes.This allows tools such as Vitest coverage to spawn the configured package manager without failing with
spawn pnpm ENOENT.Changes
command environment
vp test,vp build,vp lint, etc.package.json#packageManagerFixes #1690.