fix(cli): vp create tracking for generated VS Code settings#1700
Conversation
Post-process create results after VS Code config generation so broad .vscode ignore rules do not hide generated settings or extension recommendations from Git. Keep explicit per-file ignore rules intact and cover both monorepo and application scaffolds with snap tests.
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cab91c17f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
Fixes #1641.
This updates
vp createso generated VS Code workspace config files remain trackable when the VS Code editor option is selected.Previously, templates such as
create-vitecould generate.vscode/settings.jsonwhile also including a.gitignorepattern like:That left .vscode/settings.json ignored even though Vite+ generated it. vp create now post-processes the generated
.gitignoreafter writing VS Code editor config and appends unignore rules for:.vscode/settings.json.vscode/extensions.jsonThe fix is intentionally scoped to vp create; vp migrate behavior is unchanged.
Changes
Adds ensureGitignoreVsCodeEditorConfigs() for create-time .gitignore post-processing.
.gitignoreto include!.vscode/settings.json.