Skip to content

fix(cli): add "lib" to builtin commands#174

Merged
fengmk2 merged 1 commit intomainfrom
09-21-fix_cli_add_missing_lib_command
Sep 22, 2025
Merged

fix(cli): add "lib" to builtin commands#174
fengmk2 merged 1 commit intomainfrom
09-21-fix_cli_add_missing_lib_command

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Sep 21, 2025

It can still run without adding this logic

@fengmk2 fengmk2 changed the title fix(cli): add missing lib command fix(cli): add "lib" to builtin commands Sep 21, 2025
@fengmk2 fengmk2 self-assigned this Sep 21, 2025
@fengmk2 fengmk2 marked this pull request as ready for review September 21, 2025 12:56
@fengmk2 fengmk2 force-pushed the 09-21-refactor_cli_add_resolve_helper branch from 49ae39d to b07e3fb Compare September 21, 2025 14:56
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch 2 times, most recently from 52ecc1f to 9c148ab Compare September 21, 2025 14:57
@fengmk2 fengmk2 force-pushed the 09-21-refactor_cli_add_resolve_helper branch from b07e3fb to a2d6fd5 Compare September 21, 2025 14:57
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from 9c148ab to 45db84b Compare September 21, 2025 15:00
@fengmk2 fengmk2 force-pushed the 09-21-refactor_cli_add_resolve_helper branch 2 times, most recently from 24d7cac to bb8c75a Compare September 22, 2025 01:13
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from 45db84b to e569935 Compare September 22, 2025 01:13
@fengmk2 fengmk2 force-pushed the 09-21-refactor_cli_add_resolve_helper branch 2 times, most recently from 92f8ff4 to cb238c4 Compare September 22, 2025 01:38
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from e569935 to b82700f Compare September 22, 2025 01:38
@fengmk2 fengmk2 changed the base branch from 09-21-refactor_cli_add_resolve_helper to graphite-base/174 September 22, 2025 01:58
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from b82700f to 24b2f36 Compare September 22, 2025 01:58
@graphite-app graphite-app Bot changed the base branch from graphite-base/174 to main September 22, 2025 01:59
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from 24b2f36 to e042d94 Compare September 22, 2025 01:59
Copilot AI review requested due to automatic review settings September 22, 2025 02:54
@fengmk2 fengmk2 force-pushed the 09-21-fix_cli_add_missing_lib_command branch from e042d94 to 3e7a55b Compare September 22, 2025 02:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds "lib" to the list of builtin CLI commands to ensure consistency between the available commands and the internal command handling logic.

  • Adds "lib" to the BUILTIN_COMMANDS array
  • Adds "lib" command parsing logic in the argument parser
  • Updates snapshot test to reflect a minor documentation text change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/cli/binding/src/lib.rs Adds "lib" to builtin commands list and command parsing logic
packages/global/snap-tests/cli-helper-message/snap.txt Updates snapshot test with minor grammar fix in doc command description

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fengmk2 fengmk2 merged commit bb4d82b into main Sep 22, 2025
9 checks passed
@fengmk2 fengmk2 deleted the 09-21-fix_cli_add_missing_lib_command branch September 22, 2025 07:21
Copy link
Copy Markdown
Member Author

fengmk2 commented Sep 22, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants