Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes startup performance by lazily importing the resolveConfig function. The change moves the import from the top level to inside the resolveUniversalViteConfig function where it's actually used.
- Converts static import to dynamic import for
resolveConfig - Reduces initial bundle load time by avoiding expensive
rolldown-viteimport when cache is hit
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengmk2
approved these changes
Sep 23, 2025
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Dynamically import
resolveConfigin theresolveUniversalViteConfigfunction instead of importing it at the top level.resolveConfigimportsrolldown-vitewhich takes nearly 100ms. It's not actually used if cache is hit. Lazily importing it improves the startup time.Before:
After: