Skip to content

stype: fix clippy::useless_vec warnings rule #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brooooooklyn merged 3 commits into from
Oct 13, 2025
Merged

stype: fix clippy::useless_vec warnings rule #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1544a6a
Initial plan
Copilot Oct 11, 2025
e659a45
Fix clippy::useless_vec warnings in vite_task tests
Copilot Oct 11, 2025
a0141be
Fix cargo fmt formatting issues
Copilot Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 27 additions & 33 deletions crates/vite_task/src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ mod tests {

// Test recursive topological build
let task_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve tasks");

// Verify that all build tasks are included
Expand Down Expand Up @@ -335,7 +335,7 @@ mod tests {
.expect("Failed to load workspace");

let task_graph = workspace
.build_task_subgraph(&vec!["@test/web#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/web#build".into()], Arc::default(), false)
.expect("Failed to resolve tasks");

let has_edge = |from: &str, to: &str| -> bool {
Expand Down Expand Up @@ -366,7 +366,7 @@ mod tests {

// Test @test/utils#lint which has explicit dependencies
let task_graph = workspace
.build_task_subgraph(&vec!["@test/utils#lint".into()], Arc::default(), false)
.build_task_subgraph(&["@test/utils#lint".into()], Arc::default(), false)
.expect("Failed to resolve tasks");

let has_edge = |from: &str, to: &str| -> bool {
Expand Down Expand Up @@ -407,7 +407,7 @@ mod tests {

// Test @test/utils#lint which has explicit dependencies
let task_graph = workspace
.build_task_subgraph(&vec!["@test/utils#lint".into()], Arc::default(), false)
.build_task_subgraph(&["@test/utils#lint".into()], Arc::default(), false)
.expect("Failed to resolve tasks");

let has_edge = |from: &str, to: &str| -> bool {
Expand Down Expand Up @@ -447,7 +447,7 @@ mod tests {

// Test recursive build with topological_run=false
let task_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve tasks");

// Verify that all build tasks are included (recursive flag works)
Expand Down Expand Up @@ -496,7 +496,7 @@ mod tests {
.expect("Failed to load workspace with topological=true");

let graph_true = workspace_true
.build_task_subgraph(&vec!["@test/app#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/app#build".into()], Arc::default(), false)
.expect("Failed to resolve tasks");

with_unique_cache_path("topological_comparison_false", |cache_path_false| {
Expand All @@ -506,7 +506,7 @@ mod tests {
.expect("Failed to load workspace with topological=false");

let graph_false = workspace_false
.build_task_subgraph(&vec!["@test/app#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/app#build".into()], Arc::default(), false)
.expect("Failed to resolve tasks");

// Count edges in each graph
Expand Down Expand Up @@ -555,7 +555,7 @@ mod tests {
// Test recursive build without topological flag
// Note: Even without topological flag, cross-package dependencies are now always included
let task_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve tasks");

// Verify that all build tasks are included
Expand Down Expand Up @@ -593,11 +593,8 @@ mod tests {
.expect("Failed to load workspace");

// Test that specifying a scoped task with recursive flag returns an error
let result = workspace.build_task_subgraph(
&vec!["@test/core#build".into()],
Arc::default(),
true,
);
let result =
workspace.build_task_subgraph(&["@test/core#build".into()], Arc::default(), true);

assert!(result.is_err());
match result {
Expand All @@ -619,7 +616,7 @@ mod tests {

// Test non-recursive build of a single package
let task_graph = workspace
.build_task_subgraph(&vec!["@test/utils#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/utils#build".into()], Arc::default(), false)
.expect("Failed to resolve tasks");

// @test/utils has compound commands (3 subtasks) plus dependencies on @test/core#build
Expand All @@ -646,7 +643,7 @@ mod tests {

// Test recursive topological build with compound commands
let task_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve tasks");

// Check all tasks including subcommands
Expand Down Expand Up @@ -702,7 +699,7 @@ mod tests {

// Test recursive topological build with transitive dependencies
let task_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve tasks");

// Verify that all build tasks are included
Expand Down Expand Up @@ -746,7 +743,7 @@ mod tests {

// Test build task graph
let build_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve build tasks");

let build_tasks: Vec<_> =
Expand Down Expand Up @@ -825,7 +822,7 @@ mod tests {

// Test test task graph
let test_graph = workspace
.build_task_subgraph(&vec!["test".into()], Arc::default(), true)
.build_task_subgraph(&["test".into()], Arc::default(), true)
.expect("Failed to resolve test tasks");

let test_tasks: Vec<_> =
Expand All @@ -849,7 +846,7 @@ mod tests {

// Test specific package task
let api_build_graph = workspace
.build_task_subgraph(&vec!["@test/api#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/api#build".into()], Arc::default(), false)
.expect("Failed to resolve api build task");

let api_deps: Vec<_> =
Expand All @@ -874,11 +871,8 @@ mod tests {
.expect("Failed to load workspace");

// Test that we can't use recursive with task names containing # (would be interpreted as scope)
let result = workspace.build_task_subgraph(
&vec!["test#integration".into()],
Arc::default(),
true,
);
let result =
workspace.build_task_subgraph(&["test#integration".into()], Arc::default(), true);
assert!(result.is_err(), "Recursive run with # in task name should fail");
})
}
Expand All @@ -893,7 +887,7 @@ mod tests {

// Test app build task graph - this should show the full dependency tree
let app_build_graph = workspace
.build_task_subgraph(&vec!["@test/app#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/app#build".into()], Arc::default(), false)
.expect("Failed to resolve app build task");

// Expected task graph structure:
Expand Down Expand Up @@ -1140,7 +1134,7 @@ mod tests {

// Test resolving build task recursively - should find both packages
let build_tasks = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve build tasks recursively");

let task_names: Vec<_> =
Expand All @@ -1158,7 +1152,7 @@ mod tests {

// Test that empty-name package internal dependencies work
let empty_build = workspace
.build_task_subgraph(&vec!["#build".into()], Arc::default(), false)
.build_task_subgraph(&["#build".into()], Arc::default(), false)
.expect("Failed to resolve empty-name build");

let empty_build_tasks: Vec<_> =
Expand Down Expand Up @@ -1207,7 +1201,7 @@ mod tests {

// Test recursive build includes both nameless packages
let build_tasks = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve build tasks recursively");

let task_names: Vec<_> =
Expand All @@ -1231,7 +1225,7 @@ mod tests {
// Test that nameless packages can have different internal dependencies
// The second nameless package has more complex dependencies
let deploy_tasks = workspace
.build_task_subgraph(&vec!["deploy".into()], Arc::default(), true)
.build_task_subgraph(&["deploy".into()], Arc::default(), true)
.expect("Failed to resolve deploy tasks");

let deploy_task_names: Vec<_> =
Expand All @@ -1253,7 +1247,7 @@ mod tests {

// Verify that dependencies between nameless packages don't interfere
let test_tasks = workspace
.build_task_subgraph(&vec!["test".into()], Arc::default(), true)
.build_task_subgraph(&["test".into()], Arc::default(), true)
.expect("Failed to resolve test tasks");

let test_task_names: Vec<_> =
Expand All @@ -1268,7 +1262,7 @@ mod tests {
// The second nameless package depends on normal-package
// With topological ordering, build tasks should respect package dependencies
let build_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve build with topological");

// Helper to check edges
Expand Down Expand Up @@ -1313,7 +1307,7 @@ mod tests {

// First, test that the original scoped task works
let api_build_scoped = workspace
.build_task_subgraph(&vec!["@test/api#build".into()], Arc::default(), false)
.build_task_subgraph(&["@test/api#build".into()], Arc::default(), false)
.expect("Failed to resolve @test/api#build");

// Find the number of tasks for API build
Expand All @@ -1322,7 +1316,7 @@ mod tests {

// Test that we can resolve task with '#' in package
let app_test_scoped = workspace
.build_task_subgraph(&vec!["@test/app#test".into()], Arc::default(), false)
.build_task_subgraph(&["@test/app#test".into()], Arc::default(), false)
.expect("Failed to resolve @test/app#test");

// Should include dependencies
Expand Down
2 changes: 1 addition & 1 deletion crates/vite_task/src/schedule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ mod tests {

// Test build task graph
let build_graph = workspace
.build_task_subgraph(&vec!["build".into()], Arc::default(), true)
.build_task_subgraph(&["build".into()], Arc::default(), true)
.expect("Failed to resolve build tasks");

let plan =
Expand Down
Loading