Fix clippy::semicolon_if_nothing_returned warnings#222
Closed
Conversation
Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix clippy warning for semicolon if nothing returned
Fix clippy::semicolon_if_nothing_returned warnings
Oct 13, 2025
Member
|
@copilot resolve confict |
Author
I'm unable to resolve the merge conflict automatically because I cannot fetch the latest changes from the main branch due to authentication limitations in this environment. The main branch has moved ahead with 3 new commits since this PR was created:
These commits modify some of the same files I changed ( To resolve this conflict, you'll need to:
Alternatively, you could close this PR and I can create a fresh one based on the current main branch. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all
clippy::semicolon_if_nothing_returnedwarnings across the codebase by adding semicolons to statements that don't return values.Background
The
clippy::semicolon_if_nothing_returnedlint is part of thepedanticgroup enabled in our workspace configuration. It requires adding semicolons to the end of statements that are evaluated for their side effects rather than their return value, ensuring consistent formatting throughout the codebase.Changes
Applied automatic fixes using
cargo clippy --fixto add semicolons in:assert!,assert_eq!, etc. at the end of test closurespre_exec.run()?;)Example Fixes
Test assertions:
Side effects in if-let:
Impact
clippy::semicolon_if_nothing_returnedOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.