test: add test for vitest browser mode#235
Merged
branchseer merged 2 commits intomainfrom Oct 20, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds end-to-end snapshot tests for Vitest’s browser mode and stabilizes snapshots across platforms, especially macOS symlink paths and timing units.
- Add Vitest browser mode snap test and related fixtures
- Normalize duration outputs (including µs) and resolve tmpdir symlink to stabilize in snapshots
- Update CI to run E2E on Ubuntu/mac and install Playwright Chromium
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds @vitest/browser and playwright to catalog to support browser-mode tests |
| packages/tools/src/utils.ts | Extends unstable output normalization to include µs and adjusts duration replacement placement |
| packages/tools/src/snap-test.ts | Resolves tmpdir symlink, symlinks node_modules into temp dirs, and adds per-test platform skipping |
| packages/cli/snap-tests/yarn-install-with-options/steps.json | Adds ignoredPlatforms to skip on Linux |
| packages/cli/snap-tests/yarn-install-with-options/snap.txt | Updates expected default cwd output after symlink resolution |
| packages/cli/snap-tests/vitest-browser-mode/vitest.config.ts | Adds Vitest browser mode configuration (Playwright/Chromium) |
| packages/cli/snap-tests/vitest-browser-mode/steps.json | Defines steps for browser-mode snap test, skipping on Linux |
| packages/cli/snap-tests/vitest-browser-mode/src/* | Adds simple test and sources used by the browser-mode test |
| packages/cli/snap-tests/vitest-browser-mode/snap.txt | Snapshot for browser-mode test runs and cache behavior |
| packages/cli/snap-tests/vitest-browser-mode/package.json | Empty placeholder for test fixture |
| packages/cli/snap-tests/fingerprint-ignore-test/steps.json | Adds ignoredPlatforms to skip on Linux |
| packages/cli/package.json | Declares @vitest/browser and playwright as devDependencies for CLI package |
| .github/workflows/ci.yml | Adds Ubuntu to matrix and installs Playwright Chromium before E2E tests |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Brooooooklyn
approved these changes
Oct 20, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
branchseer
force-pushed
the
10-19-test_vitest_browser_mode
branch
from
8b46431 to
4049e8b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
This was referenced Oct 21, 2025
branchseer
added a commit
that referenced
this pull request
Oct 23, 2025
branchseer
pushed a commit
that referenced
this pull request
Mar 13, 2026
Includes: - ux: hint Escape key when no tasks match in interactive selector (#235) - docs: overhaul README.md, CLAUDE.md and add CONTRIBUTING.md (#234) https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U
2 tasks
branchseer
added a commit
that referenced
this pull request
Mar 13, 2026
## Summary - Bump vite-task from `28f371a1` to `398a147f` - Includes: hint Escape key when no tasks match in interactive selector (#235), overhaul README/CLAUDE.md and add CONTRIBUTING.md (#234) ## Test plan - [x] `cargo check` passes - [ ] CI passes https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The added vitest browser mode test will be fixed and enabled in #234