test: add test for type-aware linting#253
Merged
branchseer merged 2 commits intomainfrom Oct 24, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a snapshot test suite to verify type-aware linting functionality in oxlint. The test demonstrates that type-aware linting correctly detects changes in TypeScript type definition files and invalidates cache accordingly, while non-type-aware linting does not.
Key changes:
- New snapshot test that validates type-aware vs non-type-aware linting behavior
- Test is temporarily disabled on Linux pending a fix in a future PR
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/snap-tests/oxlint-typeaware/types.ts | Adds a simple type definition file used to test type-aware linting detection |
| packages/cli/snap-tests/oxlint-typeaware/steps.json | Defines test commands that verify cache behavior differs between type-aware and non-type-aware modes |
| packages/cli/snap-tests/oxlint-typeaware/src/index.ts | Creates a source file that imports the type, establishing a dependency relationship |
| packages/cli/snap-tests/oxlint-typeaware/snap.txt | Expected output showing cache hit for non-type-aware and cache miss for type-aware linting |
| packages/cli/snap-tests/oxlint-typeaware/package.json | Empty package.json required for the test suite structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengmk2
approved these changes
Oct 24, 2025
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Disabled on Linux for now. Will enable with a fix in a separate PR.