chore: move dependencies out of snap test case#264
Merged
branchseer merged 1 commit intomainfrom Oct 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines the vitest-browser-mode snap test by moving the @vitest/browser-playwright dependency from being test-specific to a shared catalog dependency, eliminating the need for an explicit installation step during test execution.
Key Changes:
- Added
@vitest/browser-playwrightto the shared dependency catalog and CLI package - Removed the separate installation step from the vitest-browser-mode snap test
- Updated vitest and @vitest/browser versions from 4.0.3 to 4.0.4
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added @vitest/browser-playwright v4.0.4 to the catalog and bumped vitest/browser versions |
| packages/cli/package.json | Added @vitest/browser-playwright as a catalog dependency |
| packages/cli/snap-tests/vitest-browser-mode/package.json | Removed the @vitest/browser-playwright dependency entry |
| packages/cli/snap-tests/vitest-browser-mode/steps.json | Removed the vite install command from test steps |
| packages/cli/snap-tests/vitest-browser-mode/snap.txt | Updated expected output to exclude the installation step output |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
approved these changes
Oct 28, 2025
Member
Author
Merge activity
|
branchseer
deleted the
10-28-chore_move_dependencies_out_of_snap_test_case
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
@vitest/browser-playwrightas a catalog dependencyWhat changed?
@vitest/browser-playwrightto the CLI package dependencies@vitest/browser-playwrightdependency from the vitest-browser-mode snap test package.jsonvite installbefore testsHow to test?
Why make this change?
This change streamlines the testing process by making
@vitest/browser-playwrightavailable as a catalog dependency rather than requiring it to be installed separately in each test. This eliminates the need for an explicit installation step in the vitest-browser-mode snap test, making the testing workflow more efficient and consistent.