chore: deps upgrade and clippy/fmt fix#283
Merged
Brooooooklyn merged 1 commit intomainfrom Nov 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and applies code quality improvements including lint fixes and modernized Rust idioms.
- Updated Rust nightly toolchain from 2025-08-05 to 2025-10-31
- Upgraded multiple npm packages including oxlint, vitest, and various type definitions
- Applied Rust code improvements: removed unused imports, simplified formatting, and used newer APIs
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updated Rust nightly channel to 2025-10-31 |
| pnpm-workspace.yaml | Updated versions for @types/node, oxlint, oxlint-tsgolint, and vitest packages |
| pnpm-lock.yaml | Updated lockfile reflecting dependency version changes |
| crates/vite_workspace/src/lib.rs | Modernized panic message formatting |
| crates/vite_workspace/src/error.rs | Removed unused imports (serde_json, serde_yml, wax) |
| crates/vite_tui/src/app.rs | Changed to_string() to clone() for task value |
| crates/vite_task/src/ui.rs | Simplified format string by extracting cwd_str variable |
| crates/vite_path/src/relative.rs | Changed #[allow] to #[expect] for clippy lint |
| crates/vite_glob/src/error.rs | Removed unused wax import |
| crates/fspy_test_utils/src/lib.rs | Removed unused import and modernized print formatting |
| crates/fspy_shared_unix/src/exec/mod.rs | Simplified Option handling using unwrap_or_else |
| crates/fspy_shared/src/ipc/channel/shm_io.rs | Used is_multiple_of() API and repeat_n() iterator |
| crates/fspy_shared/src/ipc/channel/mod.rs | Simplified error mapping using io::Error::other |
| crates/fspy_preload_unix/src/client/mod.rs | Removed unnecessary reference in function call |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
force-pushed
the
11-01-chore_deps_upgrade_and_clippy_fmt_fix
branch
from
cb37ba8 to
491149a
Compare
fengmk2
approved these changes
Nov 1, 2025
Member
Author
Merge activity
|
branchseer
reviewed
Nov 1, 2025
Comment on lines
-41
to
-45
| Some(format!( | ||
| "{}$ {}", | ||
| if cwd.is_empty() { format_args!("") } else { format_args!("~/{cwd}") }, | ||
| display_command | ||
| )) |
Member
There was a problem hiding this comment.
Didn't expect bumping rust version would break this...🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.