Skip to content

chore: fix typo and auto clean dir on global build#299

Merged
fengmk2 merged 1 commit intomainfrom
11-12-chore_fix_typo_and_auto_clean_dir_on_global_build
Nov 12, 2025
Merged

chore: fix typo and auto clean dir on global build#299
fengmk2 merged 1 commit intomainfrom
11-12-chore_fix_typo_and_auto_clean_dir_on_global_build

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Nov 12, 2025

No description provided.

@fengmk2 fengmk2 requested a review from Brooooooklyn November 12, 2025 03:06
Copy link
Copy Markdown
Member Author

fengmk2 commented Nov 12, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review November 12, 2025 03:06
Copilot AI review requested due to automatic review settings November 12, 2025 03:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses two minor issues: correcting a typo in the README command and enabling automatic directory cleaning for the global package build configuration.

  • Fixed typo in README: changed "tools" to "tool" in the sync-remote command
  • Added cleanDir: true to the global package's rolldown output configuration to automatically clean the dist directory before builds
  • Added pnpm install step to README instructions after syncing remote dependencies

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/global/rolldown.config.ts Enables automatic cleaning of dist directory before build
README.md Corrects command typo and adds install step to dependency sync instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2 fengmk2 force-pushed the 11-12-chore_fix_typo_and_auto_clean_dir_on_global_build branch from 1fc833e to 1c69fb2 Compare November 12, 2025 05:25
@fengmk2 fengmk2 merged commit ac7173c into main Nov 12, 2025
11 checks passed
Copy link
Copy Markdown
Member Author

fengmk2 commented Nov 12, 2025

Merge activity

@fengmk2 fengmk2 deleted the 11-12-chore_fix_typo_and_auto_clean_dir_on_global_build branch November 12, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants