Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Windows path compatibility issues in the CLI by ensuring proper path separators are used and the correct Node.js executable is invoked on Windows.
Key Changes:
- Updated path comparison in TypeScript build script to use platform-agnostic path joining
- Added Windows-specific handling to use
node.exeinstead ofnodeacross all command modules
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/build.ts | Fixed path comparison to use join() for cross-platform path separator handling |
| packages/cli/binding/src/commands/vite.rs | Added conditional logic to use node.exe on Windows |
| packages/cli/binding/src/commands/test.rs | Added conditional logic to use node.exe on Windows |
| packages/cli/binding/src/commands/lint.rs | Added conditional logic to use node.exe on Windows |
| packages/cli/binding/src/commands/lib_cmd.rs | Added conditional logic to use node.exe on Windows |
| packages/cli/binding/src/commands/fmt.rs | Added conditional logic to use node.exe on Windows |
| packages/cli/binding/src/commands/doc.rs | Added conditional logic to use node.exe on Windows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
reviewed
Nov 12, 2025
branchseer
reviewed
Nov 12, 2025
fengmk2
approved these changes
Nov 12, 2025
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.