Conversation
37a974d to
26c1f4d
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure for end-to-end testing of the vite-plus project against external ecosystem repositories. It introduces the vibe-dashboard project to the ecosystem CI test suite alongside the existing skeleton project.
- Adds ecosystem-ci configuration with repo definitions and patching scripts
- Creates a new e2e-test GitHub Actions workflow job
- Implements repository cloning and patching logic for external projects
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tmp/.gitignore | Adds gitignore for generated tgz files |
| packages/tools/src/snap-test.ts | Reformats multi-line string concatenation to single line |
| ecosystem-ci/repo.json | Defines external repositories (skeleton, vibe-dashboard) with their git references |
| ecosystem-ci/patch-project.ts | Implements project-specific patching logic to replace package references with local tgz files |
| ecosystem-ci/clone.ts | Implements repository cloning and checkout logic with validation |
| ecosystem-ci/.gitignore | Ignores cloned external project directories |
| .oxfmtrc.json | Updates formatter ignore patterns for new directories |
| .github/workflows/ci.yml | Adds new e2e-test job with matrix strategy for testing multiple projects |
| .github/actions/clone/action.yml | Extends clone action to support ecosystem CI projects |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:358
- The 'done' job's needs list is missing the newly added 'e2e-test' job. This means the workflow can complete successfully even if the e2e-test job fails. Add '- e2e-test' to the needs list to ensure the workflow waits for and considers the e2e-test results.
needs:
- test
- lint
- run
- cli-e2e-test
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
26c1f4d to
fc87244
Compare
VP-98 add e2e test after bundle release merge
First, use https://github.com/voidzero-dev/vibe-dashboard as the test library, pack vite+ into a tgz file, and then rely on this temporary tgz file in vibe-dashboard to achieve e2e validation. cc brooklyn |
fc87244 to
a17e9f8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a17e9f8 to
1badbc5
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: LongYinan <lynweklm@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: LongYinan <lynweklm@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|

Add https://github.com/voidzero-dev/vibe-dashboard and https://github.com/skeletonlabs/skeleton as e2e test projects.
Override the
viteandvitestin the skeleton, then execute all build commands and the test command.Close VP-98