Skip to content

ci: add vibe-dashboard to e2e test#325

Merged
Brooooooklyn merged 4 commits intomainfrom
11-28-ci_add_vibe-dashboard_to_e2e_test
Dec 1, 2025
Merged

ci: add vibe-dashboard to e2e test#325
Brooooooklyn merged 4 commits intomainfrom
11-28-ci_add_vibe-dashboard_to_e2e_test

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn commented Nov 28, 2025

Add https://github.com/voidzero-dev/vibe-dashboard and https://github.com/skeletonlabs/skeleton as e2e test projects.

Override the vite and vitest in the skeleton, then execute all build commands and the test command.

Close VP-98

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn force-pushed the 11-28-ci_add_vibe-dashboard_to_e2e_test branch 12 times, most recently from 37a974d to 26c1f4d Compare November 28, 2025 12:56
@Brooooooklyn Brooooooklyn marked this pull request as ready for review November 28, 2025 13:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds infrastructure for end-to-end testing of the vite-plus project against external ecosystem repositories. It introduces the vibe-dashboard project to the ecosystem CI test suite alongside the existing skeleton project.

  • Adds ecosystem-ci configuration with repo definitions and patching scripts
  • Creates a new e2e-test GitHub Actions workflow job
  • Implements repository cloning and patching logic for external projects

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tmp/.gitignore Adds gitignore for generated tgz files
packages/tools/src/snap-test.ts Reformats multi-line string concatenation to single line
ecosystem-ci/repo.json Defines external repositories (skeleton, vibe-dashboard) with their git references
ecosystem-ci/patch-project.ts Implements project-specific patching logic to replace package references with local tgz files
ecosystem-ci/clone.ts Implements repository cloning and checkout logic with validation
ecosystem-ci/.gitignore Ignores cloned external project directories
.oxfmtrc.json Updates formatter ignore patterns for new directories
.github/workflows/ci.yml Adds new e2e-test job with matrix strategy for testing multiple projects
.github/actions/clone/action.yml Extends clone action to support ecosystem CI projects
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:358

  • The 'done' job's needs list is missing the newly added 'e2e-test' job. This means the workflow can complete successfully even if the e2e-test job fails. Add '- e2e-test' to the needs list to ensure the workflow waits for and considers the e2e-test results.
    needs:
      - test
      - lint
      - run
      - cli-e2e-test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tmp/.gitignore Outdated
Comment thread ecosystem-ci/patch-project.ts
Comment thread ecosystem-ci/patch-project.ts
Comment thread .oxfmtrc.json Outdated
Comment thread .github/workflows/ci.yml Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ecosystem-ci/patch-project.ts
@Brooooooklyn Brooooooklyn force-pushed the 11-28-ci_add_vibe-dashboard_to_e2e_test branch from 26c1f4d to fc87244 Compare November 28, 2025 13:11
@linear
Copy link
Copy Markdown

linear Bot commented Nov 28, 2025

VP-98 add e2e test after bundle release merge

#271

First, use https://github.com/voidzero-dev/vibe-dashboard as the test library, pack vite+ into a tgz file, and then rely on this temporary tgz file in vibe-dashboard to achieve e2e validation.

cc brooklyn

Copilot AI review requested due to automatic review settings November 28, 2025 13:42
@Brooooooklyn Brooooooklyn force-pushed the 11-28-ci_add_vibe-dashboard_to_e2e_test branch from fc87244 to a17e9f8 Compare November 28, 2025 13:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ecosystem-ci/patch-project.ts
Comment thread ecosystem-ci/clone.ts
Comment thread ecosystem-ci/patch-project.ts
Comment thread ecosystem-ci/patch-project.ts
Comment thread ecosystem-ci/patch-project.ts
Comment thread .github/workflows/ci.yml Outdated
Comment thread ecosystem-ci/clone.ts
@Brooooooklyn Brooooooklyn force-pushed the 11-28-ci_add_vibe-dashboard_to_e2e_test branch from a17e9f8 to 1badbc5 Compare December 1, 2025 01:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: LongYinan <lynweklm@gmail.com>
Copilot AI review requested due to automatic review settings December 1, 2025 01:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: LongYinan <lynweklm@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .oxfmtrc.json
Comment thread ecosystem-ci/patch-project.ts
Comment thread .github/workflows/ci.yml
Comment thread .github/actions/clone/action.yml
Comment thread .github/workflows/ci.yml
Comment thread ecosystem-ci/clone.ts
Comment thread .github/workflows/ci.yml
Comment thread ecosystem-ci/patch-project.ts
Comment thread ecosystem-ci/patch-project.ts
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Dec 1, 2025

Merge activity

  • Dec 1, 1:46 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 1, 1:46 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 39119e3 into main Dec 1, 2025
13 checks passed
@Brooooooklyn Brooooooklyn deleted the 11-28-ci_add_vibe-dashboard_to_e2e_test branch December 1, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants