Skip to content

chore(cli): re-export cjs entry for defineConfig#336

Merged
Brooooooklyn merged 1 commit intomainfrom
12-09-chore_cli_re-export_cjs_entry_for_defineconfig
Dec 9, 2025
Merged

chore(cli): re-export cjs entry for defineConfig#336
Brooooooklyn merged 1 commit intomainfrom
12-09-chore_cli_re-export_cjs_entry_for_defineconfig

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings December 9, 2025 03:09
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/index.cts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CommonJS support for the CLI package by creating a CJS entry point that re-exports functionality from both the core and test packages. The changes simplify export management by replacing individual named exports with wildcard exports.

  • Replaced individual named exports with export * from @voidzero-dev/vite-plus-test/config in the ESM entry point
  • Created a new CommonJS entry point (index.cts) that spreads exports from both vite-plus-core and vite-plus-test
  • Added the require field to package.json exports to point to the compiled CJS file

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/cli/src/index.ts Simplified exports by replacing individual named exports with wildcard export from test config
packages/cli/src/index.cts New CommonJS entry point that combines exports from core and test packages
packages/cli/package.json Added require field to exports configuration to support CommonJS consumers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/src/index.ts
@Brooooooklyn Brooooooklyn requested a review from fengmk2 December 9, 2025 03:26
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Dec 9, 2025

Merge activity

  • Dec 9, 3:51 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 9, 3:51 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 3f2b8a1 into main Dec 9, 2025
19 checks passed
@Brooooooklyn Brooooooklyn deleted the 12-09-chore_cli_re-export_cjs_entry_for_defineconfig branch December 9, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants