Skip to content

test: fix unstable snap-test#365

Merged
fengmk2 merged 1 commit intomainfrom
12-24-test_fix_unstable_snap-test
Dec 24, 2025
Merged

test: fix unstable snap-test#365
fengmk2 merged 1 commit intomainfrom
12-24-test_fix_unstable_snap-test

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Dec 24, 2025

No description provided.

@fengmk2 fengmk2 requested a review from Brooooooklyn December 24, 2025 04:39
@fengmk2 fengmk2 marked this pull request as ready for review December 24, 2025 04:39
Copilot AI review requested due to automatic review settings December 24, 2025 04:39
@fengmk2 fengmk2 self-assigned this Dec 24, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes a flaky snapshot test by simplifying the build configuration to only generate CJS output instead of both ESM and CJS formats. This reduces the complexity of the test and makes it more stable.

Key changes:

  • Updated tsdown configuration to build only CJS format
  • Updated snapshot to reflect the simplified build output

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/cli/snap-tests/command-lib-monorepo/packages/hello/tsdown.config.ts Removed 'esm' from the format array, keeping only 'cjs' format
packages/cli/snap-tests/command-lib-monorepo/snap.txt Updated snapshot to remove ESM-related build output and index.mjs file reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2 fengmk2 merged commit 2744988 into main Dec 24, 2025
18 of 19 checks passed
Copy link
Copy Markdown
Member Author

fengmk2 commented Dec 24, 2025

Merge activity

@fengmk2 fengmk2 deleted the 12-24-test_fix_unstable_snap-test branch December 24, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants