fix(test): deps and sideEffects#401
Merged
Brooooooklyn merged 1 commit intomainfrom Jan 7, 2026
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves package metadata by correcting dependency categorization and enabling better tree-shaking. The changes reorganize picomatch from runtime to build-time dependencies in the test package, remove a non-existent export reference, and add proper side-effects declaration to the CLI package.
- Moved
picomatchfrom dependencies to devDependencies in the test package - Removed unused
buildSingleexport from CLI lib entrypoint - Added
"sideEffects": falseto CLI package for better tree-shaking
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated lockfile to reflect picomatch moved from test dependencies to devDependencies |
| packages/test/package.json | Moved picomatch from dependencies to devDependencies (not used at runtime) |
| packages/cli/src/lib.ts | Removed non-existent buildSingle export |
| packages/cli/package.json | Added sideEffects: false for better tree-shaking optimization |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
reviewed
Jan 7, 2026
fengmk2
approved these changes
Jan 7, 2026
d020050 to
4363256
Compare
e5e902e to
3091f7d
Compare
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Sets side-effect flags and cleans up exports/deps.
packages/cli/package.jsonwith"sideEffects": falsebuildSinglefrompackages/cli/src/lib.tsre-exportspicomatchfrompackages/testdependencies to devDependencies; updatespnpm-lock.yamlaccordinglyWritten by Cursor Bugbot for commit 3091f7d. This will update automatically on new commits. Configure here.