Skip to content

fix(test): deps and sideEffects#401

Merged
Brooooooklyn merged 1 commit intomainfrom
01-07-fix_test_deps_and_sideeffects
Jan 7, 2026
Merged

fix(test): deps and sideEffects#401
Brooooooklyn merged 1 commit intomainfrom
01-07-fix_test_deps_and_sideeffects

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn commented Jan 7, 2026

Note

Sets side-effect flags and cleans up exports/deps.

  • Marks packages/cli/package.json with "sideEffects": false
  • Removes buildSingle from packages/cli/src/lib.ts re-exports
  • Moves picomatch from packages/test dependencies to devDependencies; updates pnpm-lock.yaml accordingly

Written by Cursor Bugbot for commit 3091f7d. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings January 7, 2026 07:11
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Jan 7, 2026

@Brooooooklyn Brooooooklyn changed the base branch from 01-06-fix_test_bundle_the_deps_.d.ts_file to graphite-base/401 January 7, 2026 07:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves package metadata by correcting dependency categorization and enabling better tree-shaking. The changes reorganize picomatch from runtime to build-time dependencies in the test package, remove a non-existent export reference, and add proper side-effects declaration to the CLI package.

  • Moved picomatch from dependencies to devDependencies in the test package
  • Removed unused buildSingle export from CLI lib entrypoint
  • Added "sideEffects": false to CLI package for better tree-shaking

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pnpm-lock.yaml Updated lockfile to reflect picomatch moved from test dependencies to devDependencies
packages/test/package.json Moved picomatch from dependencies to devDependencies (not used at runtime)
packages/cli/src/lib.ts Removed non-existent buildSingle export
packages/cli/package.json Added sideEffects: false for better tree-shaking optimization
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/test/package.json
Comment thread packages/cli/package.json
@Brooooooklyn Brooooooklyn force-pushed the 01-07-fix_test_deps_and_sideeffects branch from e5e902e to 3091f7d Compare January 7, 2026 09:10
@graphite-app graphite-app Bot changed the base branch from graphite-base/401 to main January 7, 2026 09:10
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 7, 2026

Merge activity

  • Jan 7, 9:10 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jan 7, 9:26 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 1bfc5e2 into main Jan 7, 2026
17 checks passed
@Brooooooklyn Brooooooklyn deleted the 01-07-fix_test_deps_and_sideeffects branch January 7, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants