fix(test): add @standard-schema/spec to EXTERNAL_BLOCKLIST#498
Merged
Brooooooklyn merged 1 commit intomainfrom Jan 24, 2026
Merged
fix(test): add @standard-schema/spec to EXTERNAL_BLOCKLIST#498Brooooooklyn merged 1 commit intomainfrom
Brooooooklyn merged 1 commit intomainfrom
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
commented
Jan 24, 2026
fengmk2
force-pushed
the
fix-vitest-typeonly-import
branch
from
6cf857b to
6455846
Compare
Deploying vite-plus with
|
| Latest commit: |
2ceacf4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0270265.vite-plus.pages.dev |
| Branch Preview URL: | https://graphite-base-497.vite-plus.pages.dev |
fengmk2
force-pushed
the
fix-vitest-typeonly-import
branch
from
6455846 to
03bd974
Compare
fengmk2
requested review from
Brooooooklyn and
Copilot
and removed request for
Copilot
fengmk2
force-pushed
the
fix-vitest-typeonly-import
branch
from
03bd974 to
2ceacf4
Compare
VP-165 TypeCheckError: Cannot find module '@vitest/runner' or its corresponding type declarations
script: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript type resolution error by properly handling @standard-schema/spec, which is imported by @vitest/expect in type definitions. The package was not detected during the build process because collectLeafDependencies() only scans .js files, causing TypeScript to fail when trying to resolve types.
Changes:
- Added
@standard-schema/specas a runtime dependency and to the external blocklist - Updated pnpm-lock.yaml to use version 1.1.0 (matching @vitest/expect@4.0.17 requirements)
- Updated BUNDLING.md documentation to reflect the new external package
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/test/package.json | Added @standard-schema/spec@^1.1.0 to dependencies to ensure TypeScript can resolve types |
| packages/test/build.ts | Added @standard-schema/spec to EXTERNAL_BLOCKLIST to prevent bundling |
| packages/test/BUNDLING.md | Updated documentation table and code example to include the new external package |
| pnpm-lock.yaml | Updated package resolution from version 1.0.0 to 1.1.0, consistent with @vitest/expect@4.0.17 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
approved these changes
Jan 24, 2026
Member
Merge activity
|
@vitest/expect imports StandardSchemaV1 from @standard-schema/spec in its type definitions only (not in JS files). Since collectLeafDependencies() only scans .js files, this package was not detected and bundled. Fix by adding @standard-schema/spec to EXTERNAL_BLOCKLIST and as a runtime dependency, allowing TypeScript to resolve types through normal node_modules resolution.
Brooooooklyn
force-pushed
the
fix-vitest-typeonly-import
branch
from
2ceacf4 to
2c3a2d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vitest/expect imports StandardSchemaV1 from @standard-schema/spec in
its type definitions only (not in JS files). Since collectLeafDependencies()
only scans .js files, this package was not detected and bundled.
Fix by adding @standard-schema/spec to EXTERNAL_BLOCKLIST and as a
runtime dependency, allowing TypeScript to resolve types through
normal node_modules resolution.
Note
Ensures @standard-schema/spec (types used by
@vitest/expect) is installed and not bundled so TypeScript can resolve it while Rolldown keeps it external.@standard-schema/spectoEXTERNAL_BLOCKLISTinbuild.tsand document it inBUNDLING.md@standard-schema/spec@^1.1.0inpackages/test/package.json; update lockfile and align@vitest/expectto use 1.1.0This fixes missing-type errors without changing runtime code paths.
Written by Cursor Bugbot for commit 2c3a2d6. This will update automatically on new commits. Configure here.