Skip to content

ci: add x86 macOS release#517

Merged
Brooooooklyn merged 1 commit intomainfrom
01-29-ci_add_x86_macos_release
Jan 30, 2026
Merged

ci: add x86 macOS release#517
Brooooooklyn merged 1 commit intomainfrom
01-29-ci_add_x86_macos_release

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn commented Jan 29, 2026

Note

Medium Risk
Updates the release build matrix and published native targets, which can affect release pipeline behavior and artifact completeness for macOS users.

Overview
Intel macOS release support: the release workflow now builds Rust/N-API artifacts for x86_64-apple-darwin in addition to existing targets.

Both packages/cli and packages/global expand their napi.targets lists to include x86_64-apple-darwin, enabling publishing/installing native binaries for Intel Macs.

Written by Cursor Bugbot for commit a94751d. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings January 29, 2026 03:22
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Jan 29, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a macOS x86_64 build target to the release workflow so that release builds can produce artifacts for Intel macOS in addition to Apple Silicon.

Changes:

  • Extend the build-rust matrix in the Release workflow to include x86_64-apple-darwin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56b5827c61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_add_x86_macos_release branch from 56b5827 to a94adc1 Compare January 29, 2026 04:06
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread packages/cli/package.json
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_activate_release_build_in_upgrade-deps branch from f638b4e to 12ecec6 Compare January 29, 2026 04:13
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_add_x86_macos_release branch 2 times, most recently from 720f181 to cb52982 Compare January 29, 2026 05:31
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_activate_release_build_in_upgrade-deps branch from 12ecec6 to 0a34242 Compare January 29, 2026 05:31
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_activate_release_build_in_upgrade-deps branch from 0a34242 to 9a17d37 Compare January 29, 2026 07:11
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_add_x86_macos_release branch 2 times, most recently from 6a2a1a3 to 30e2dc1 Compare January 30, 2026 08:20
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_activate_release_build_in_upgrade-deps branch from 9a17d37 to 9e435c9 Compare January 30, 2026 08:20
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Jan 30, 2026

Merge activity

  • Jan 30, 8:50 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 30, 8:52 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 30, 9:01 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn changed the base branch from 01-29-ci_activate_release_build_in_upgrade-deps to graphite-base/517 January 30, 2026 08:50
@Brooooooklyn Brooooooklyn changed the base branch from graphite-base/517 to main January 30, 2026 08:50
@Brooooooklyn Brooooooklyn force-pushed the 01-29-ci_add_x86_macos_release branch from 30e2dc1 to a94751d Compare January 30, 2026 08:51
@Brooooooklyn Brooooooklyn merged commit 833c515 into main Jan 30, 2026
18 checks passed
@Brooooooklyn Brooooooklyn deleted the 01-29-ci_add_x86_macos_release branch January 30, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants