Skip to content

chore(ci): add timestamp to snapshot version for better readability#538

Merged
fengmk2 merged 1 commit intomainfrom
hyf_1931289319023
Feb 5, 2026
Merged

chore(ci): add timestamp to snapshot version for better readability#538
fengmk2 merged 1 commit intomainfrom
hyf_1931289319023

Conversation

@hyf0
Copy link
Copy Markdown
Contributor

@hyf0 hyf0 commented Feb 4, 2026

Summary

  • Add .github/actions/set-snapshot-version composite action to compute snapshot versions
  • Change version format from 0.0.0-{sha} to 0.0.0-{sha}.{timestamp} for better readability
  • Add prepare job to compute version once at workflow start and pass to downstream jobs

Test plan

  • Verify the release workflow runs successfully
  • Check that the version string in release artifacts follows the new format

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings February 4, 2026 15:57
@hyf0 hyf0 force-pushed the hyf_1931289319023 branch from ef48eaa to 275594e Compare February 4, 2026 15:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the snapshot version format for releases by adding a timestamp component and refactoring the workflow to compute the version once at the start.

Changes:

  • Created a new composite action .github/actions/set-snapshot-version that generates snapshot versions in the format 0.0.0-{short-sha}.{timestamp}
  • Refactored the release workflow to compute the version once in a dedicated prepare job and pass it to downstream jobs via outputs
  • Changed the version format from 0.0.0-{sha} to 0.0.0-{short-sha}.{timestamp} for better readability and chronological ordering

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/actions/set-snapshot-version/action.yml New composite action that computes snapshot version with 8-character SHA and UTC timestamp in YYYYMMDD-HHMM format
.github/workflows/release.yml Added prepare job to compute version once; updated build-rust and Release jobs to depend on prepare and use its version output; removed global VERSION environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Feb 5, 2026

@hyf0 Commits must have verified signatures.

@hyf0 hyf0 force-pushed the hyf_1931289319023 branch from 275594e to 7241bff Compare February 5, 2026 03:34
Version format changes from `0.0.0-{sha}` to `0.0.0-{sha}.{timestamp}`,
making it easier to identify when a build was created.

- Add .github/actions/set-snapshot-version composite action
- Add prepare job to compute version once at workflow start
- Pass version to build-rust and Release jobs via job outputs

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hyf0 hyf0 force-pushed the hyf_1931289319023 branch from 7241bff to 527c0b6 Compare February 5, 2026 03:36
@hyf0
Copy link
Copy Markdown
Contributor Author

hyf0 commented Feb 5, 2026

@hyf0 Commits must have verified signatures.

Fixed.

Very weird. I should've sighed by default. I configured this in the rolldown repo before. I thought it was claude's problem, but https://github.com/voidzero-dev/vite-plus/pull/542/commits shows both commits are also sighed.

Copy link
Copy Markdown
Member

fengmk2 commented Feb 5, 2026

Merge activity

  • Feb 5, 3:56 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 5, 3:56 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2 fengmk2 merged commit bdf958b into main Feb 5, 2026
16 checks passed
@fengmk2 fengmk2 deleted the hyf_1931289319023 branch February 5, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants