Skip to content

refactor: add EnvConfig for centralized env var management #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 8 commits into from
Feb 9, 2026
Merged

refactor: add EnvConfig for centralized env var management #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad77234
refactor: add EnvConfig with global + thread-local test override
fengmk2 Feb 8, 2026
0d6c546
refactor: migrate config.rs and package_metadata.rs tests to EnvConfi…
fengmk2 Feb 8, 2026
b384600
refactor: migrate bin_config, setup, use, package_metadata, global_in…
fengmk2 Feb 8, 2026
c65f8d7
style: cargo fmt
fengmk2 Feb 8, 2026
ce17658
fix: use cross-platform temp path in home.rs test for Windows CI
fengmk2 Feb 8, 2026
95be9da
refactor: remove vite_log from EnvConfig, keep direct env read in tra…
fengmk2 Feb 8, 2026
b973ec7
refactor: centralize env var names in env_vars module
fengmk2 Feb 9, 2026
4ef8184
fix: remove intentional typo from doc comment to pass typos linter
fengmk2 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 12 additions & 45 deletions crates/vite_global_cli/src/commands/env/bin_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,16 @@ impl BinConfig {

#[cfg(test)]
mod tests {
use serial_test::serial;
use tempfile::TempDir;

use super::*;

#[tokio::test]
#[serial]
async fn test_save_and_load() {
let temp_dir = TempDir::new().unwrap();

// SAFETY: This test runs in isolation with serial_test
unsafe {
std::env::set_var("VITE_PLUS_HOME", temp_dir.path());
}
let _guard = vite_shared::EnvConfig::test_guard(
vite_shared::EnvConfig::for_test_with_home(temp_dir.path()),
);

let config = BinConfig::new(
"tsc".to_string(),
Expand All @@ -142,22 +138,14 @@ mod tests {
assert_eq!(loaded.package, "typescript");
assert_eq!(loaded.version, "5.0.0");
assert_eq!(loaded.node_version, "20.18.0");

// Clean up env var
unsafe {
std::env::remove_var("VITE_PLUS_HOME");
}
}

#[tokio::test]
#[serial]
async fn test_find_by_package() {
let temp_dir = TempDir::new().unwrap();

// SAFETY: This test runs in isolation with serial_test
unsafe {
std::env::set_var("VITE_PLUS_HOME", temp_dir.path());
}
let _guard = vite_shared::EnvConfig::test_guard(
vite_shared::EnvConfig::for_test_with_home(temp_dir.path()),
);

// Create configs for typescript (tsc, tsserver)
let tsc = BinConfig::new(
Expand Down Expand Up @@ -197,22 +185,14 @@ mod tests {

let nonexistent_bins = BinConfig::find_by_package("nonexistent").await.unwrap();
assert!(nonexistent_bins.is_empty());

// Clean up env var
unsafe {
std::env::remove_var("VITE_PLUS_HOME");
}
}

#[tokio::test]
#[serial]
async fn test_delete() {
let temp_dir = TempDir::new().unwrap();

// SAFETY: This test runs in isolation with serial_test
unsafe {
std::env::set_var("VITE_PLUS_HOME", temp_dir.path());
}
let _guard = vite_shared::EnvConfig::test_guard(
vite_shared::EnvConfig::for_test_with_home(temp_dir.path()),
);

let config = BinConfig::new(
"tsc".to_string(),
Expand All @@ -235,29 +215,16 @@ mod tests {

// Delete again should not error
BinConfig::delete("tsc").await.unwrap();

// Clean up env var
unsafe {
std::env::remove_var("VITE_PLUS_HOME");
}
}

#[tokio::test]
#[serial]
async fn test_load_nonexistent() {
let temp_dir = TempDir::new().unwrap();

// SAFETY: This test runs in isolation with serial_test
unsafe {
std::env::set_var("VITE_PLUS_HOME", temp_dir.path());
}
let _guard = vite_shared::EnvConfig::test_guard(
vite_shared::EnvConfig::for_test_with_home(temp_dir.path()),
);

let loaded = BinConfig::load("nonexistent").await.unwrap();
assert!(loaded.is_none());

// Clean up env var
unsafe {
std::env::remove_var("VITE_PLUS_HOME");
}
}
}
Loading
Loading