Conversation
Member
Author
Add `vpx` as a standalone binary (symlink to `vp`) that checks local `node_modules/.bin` first, then falls back to `vp dlx` for remote download. This is analogous to how `npx` works. - Local binary lookup walks up from cwd checking node_modules/.bin - Version specs (e.g., `eslint@9`) skip local lookup and go remote - Supports --package/-p, --shell-mode/-c, --silent/-s flags - Shim created by `vp env setup` alongside node/npm/npx - On Windows, uses `vp env exec vpx` pattern like other shims
Add two intermediate resolution steps to vpx to match npx behavior: local node_modules/.bin -> global vp packages -> system PATH -> remote download - Make dispatch helpers (find_package_for_binary, locate_package_binary, ensure_installed, locate_tool) pub(crate) for reuse by vpx - Add find_global_binary() to check vp globally installed packages - Add find_on_path() to check system PATH excluding vite-plus bin dir - Add prepend_node_modules_bin_to_path() to prepend node_modules/.bin dirs to PATH before executing any found binary - Update RFC with new lookup order and implementation architecture - Add command-vpx-pnpm10 snap test
Update the RFC to accurately reflect the current implementation: - Add global package and PATH lookup to summary and comparison table - Fix monorepo edge case: walker goes to filesystem root, not workspace root - Add JS binary handling for global packages - Update error handling to mention all resolution steps - Add security considerations for global packages and PATH exclusion - Remove stale implementation plan and testing strategy sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
vpxas a standalone binary (symlink tovp) that checks localnode_modules/.binfirst, then falls back tovp dlxfor remotedownload. This is analogous to how
npxworks.eslint@9) skip local lookup and go remotevp env setupalongside node/npm/npxvp env exec vpxpattern like other shims