Closed
Conversation
Signed-off-by: branchseer <3612422+branchseer@users.noreply.github.com>
branchseer
added a commit
that referenced
this pull request
Feb 24, 2026
The ANSI stripping added in 4754dbc was incorrect — the empty PR #625 proves rolldown doesn't break tests. The real issue was that clap help text contains ANSI codes which should be preserved in snapshots as-is. Changes: - Revert ANSI escape code stripping from replaceUnstableOutput - Restore command-helper and command-vp-alias snaps with ANSI codes - Update vite-task rev to cc005960 (includes flush fix for reporter) - Update cache-scripts-default snap: flush fix makes script stdout visible via Stdio::inherit() - Remove temporary local vite-task patch from Cargo.toml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
branchseer
added a commit
that referenced
this pull request
Feb 25, 2026
The ANSI stripping added in 4754dbc was incorrect — the empty PR #625 proves rolldown doesn't break tests. The real issue was that clap help text contains ANSI codes which should be preserved in snapshots as-is. Changes: - Revert ANSI escape code stripping from replaceUnstableOutput - Restore command-helper and command-vp-alias snaps with ANSI codes - Update vite-task rev to cc005960 (includes flush fix for reporter) - Update cache-scripts-default snap: flush fix makes script stdout visible via Stdio::inherit() - Remove temporary local vite-task patch from Cargo.toml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.