feat: implement glob pattern matching with last-match-wins semantics

[fengmk2]

• Add vite_glob crate for efficient glob pattern matching
• Implement GlobPatternSet with support for negated patterns (!)
• Follow gitignore-like semantics: last matching pattern wins
• Support workspace exclusion patterns in pnpm/npm/yarn workspaces
• Add comprehensive tests for various glob scenarios

🤖 Generated with Claude Code

[Boshen]

Can you also test https://github.com/oxc-project/fast-glob

[fengmk2]

Can you also test https://github.com/oxc-project/fast-glob

The amount of code is similar, but Glob parsing needs to be done every time, which would likely result in some performance degradation https://github.com/voidzero-dev/vite-plus/pull/67/files.
Also, we need wax's walk function to traverse directories, so we can only replace part of wax's functionality.
It seems more appropriate to just use wax as a single dependency.

[Brooooooklyn]

cursor review

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

---

[Copilot]

Pull Request Overview

This PR implements efficient glob pattern matching with last-match-wins semantics for workspace exclusion patterns. The implementation follows gitignore-like behavior where negated patterns (!pattern) override earlier matches.

• Adds a new vite_glob crate with a GlobPatternSet that supports negated patterns
• Replaces compact_str usage with vite_str::Str across multiple crates
• Refactors workspace pattern handling to use the new glob system with proper last-match-wins semantics

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/vite_glob/src/lib.rs	New glob pattern matching implementation with comprehensive tests
crates/vite_glob/Cargo.toml	New crate configuration
crates/vite_package_manager/src/lib.rs	Refactored workspace glob handling to use new pattern system
crates/vite_package_manager/src/package.rs	Extracted PackageJson and related types from lib.rs
crates/vite_package_manager/Cargo.toml	Updated dependencies to include vite_glob and vite_str
crates/vite_task/src/config/workspace.rs	String type conversion updates
crates/vite_error/src/lib.rs	Removed compact_str dependency
crates/vite_error/Cargo.toml	Updated dependencies
Cargo.toml	Added vite_glob workspace dependency

Comments suppressed due to low confidence (1)

crates/vite_package_manager/src/lib.rs:1

• The pattern cloning on lines 70 and 72 creates unnecessary allocations. Consider collecting patterns into inclusions and all vectors in a single pass without cloning, or use references where possible.

pub mod package;

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[fengmk2]

@branchseer Check if #63 and #68 can be merged, as vite install needs to pass through more default environment variables, and the functionality depends on these two PRs.

[fengmk2]

• feat: support wildcard environment variable patterns #76
• feat: implement glob pattern matching with last-match-wins semantics #63 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[fengmk2]

Merge activity

• Sep 13, 10:01 AM UTC: @fengmk2 merged this pull request with Graphite.