Skip to content

feat(cli): Install wrapper bin/ox(lint|fmt) for oxc-vscode#633

Merged
fengmk2 merged 1 commit intomainfrom
02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode
Feb 26, 2026
Merged

feat(cli): Install wrapper bin/ox(lint|fmt) for oxc-vscode#633
fengmk2 merged 1 commit intomainfrom
02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode

Conversation

@leaysgur
Copy link
Copy Markdown
Contributor

@leaysgur leaysgur commented Feb 26, 2026

Fixes #629

  • Implement
  • Test with VSCode
  • Add snapshot tests

@leaysgur leaysgur changed the title feat(cli): Install wrapper bin/ox(lint|fmt) for oxc-vscode feat(cli): Install wrapper bin/ox(lint|fmt) for oxc-vscode Feb 26, 2026
@leaysgur
Copy link
Copy Markdown
Contributor Author

Tested:

  • Release this branch with test tag
  • Create new project and pnpm init
  • Install vite-plus
    • vite-plus@0.0.0-g28c55a1f.20260226-0707
  • Open package.json with VSCode and oxc-vscode
  • Right click and "Format Document"
    • 👉🏻 Oxfmt seems working
  • Create dummy main.ts with debugger
    • 👉🏻 Oxlint reports no-debugger
    • image

@leaysgur leaysgur force-pushed the 02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode branch from 28c55a1 to f3efd62 Compare February 26, 2026 08:05
@leaysgur leaysgur requested a review from fengmk2 February 26, 2026 08:06
@leaysgur
Copy link
Copy Markdown
Contributor Author

@fengmk2 I think it's ready now. Could you please review it?

@leaysgur leaysgur force-pushed the 02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode branch from f3efd62 to 091ff73 Compare February 26, 2026 08:09
@leaysgur
Copy link
Copy Markdown
Contributor Author

Hm... CI on Windows is failing.

According to Claude:

On Windows, cross-spawn (used by @yarnpkg/shell) resolves commands via PATHEXT (.CMD, .EXE, etc.) before trying extensionless files.

So even though bin/ is first in PATH, node_modules/.bin/oxlint.cmd wins over the extensionless bin/oxlint wrapper.

Do you think it's reasonable to ignore win32?

@leaysgur leaysgur force-pushed the 02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode branch from 091ff73 to a511018 Compare February 26, 2026 09:45
@leaysgur
Copy link
Copy Markdown
Contributor Author

For now, I've added win32 to ignoredPlatforms.

I don't think there's any actual problem, but please let me know if you have any alternatives. 🙏🏻

@leaysgur leaysgur requested a review from fengmk2 February 26, 2026 09:59
Copy link
Copy Markdown
Member

fengmk2 commented Feb 26, 2026

Merge activity

  • Feb 26, 10:00 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 10:01 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 26, 10:16 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2 fengmk2 force-pushed the 02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode branch from a511018 to b073c4f Compare February 26, 2026 10:00
@fengmk2 fengmk2 merged commit 52709db into main Feb 26, 2026
17 checks passed
@fengmk2 fengmk2 deleted the 02-26-feat_cli_install_wrapper_bin_ox_lint_fmt_for_oxc-vscode branch February 26, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make oxc-vscode work with Vite+ environments

2 participants