fix(pack): replace "tsdown" with "vp pack" in error messages#642
fix(pack): replace "tsdown" with "vp pack" in error messages#642
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cpojer
left a comment
There was a problem hiding this comment.
Wowza this is shaky.
Can we not instead do something like setting an env var if tsdown is run in a Vite+ context (or any other way of passing config to tsdown), and change the printing in tsdown based on whether the env var is set?
Yes, it currently seems that any upstream code changes will cause string replacement failures. However, the good news is that the dependency auto-upgrading GitHub Action will handle the failure logic via Claude Code, which will attempt to automatically update these replacement logics. https://github.com/voidzero-dev/vite-plus/blob/main/.github/workflows/upgrade-deps.yml I will create a follow-up issue after the Alpha release, especially after we have open-sourced it, to propose a CLI brand word replacement solution to upstream projects like Vite, tsdown, oxc, etc. |
Add brandTsdown() build-time patching to replace upstream "tsdown" branding in the bundled error message when no input files are found. Follows the same post-build branding pattern as brandVitest().
Stack trace file paths and line numbers change across builds, making snap tests unstable. Strip " at ..." lines in replaceUnstableOutput.

Add brandTsdown() build-time patching to replace upstream "tsdown"
branding in the bundled error message when no input files are found.
Follows the same post-build branding pattern as brandVitest().